Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.11 Support #875

Merged
merged 4 commits into from
Jan 21, 2023
Merged

Add Python 3.11 Support #875

merged 4 commits into from
Jan 21, 2023

Conversation

b-butler
Copy link
Member

@b-butler b-butler commented Dec 7, 2022

Description

Support Python 3.11 officially with package tags and CI tests.

Motivation and Context

Update to the latest Python.

Checklist:

@b-butler b-butler requested review from a team as code owners December 7, 2022 18:31
@b-butler b-butler requested review from vyasr and Tobias-Dwyer and removed request for a team December 7, 2022 18:31
@b-butler b-butler marked this pull request as draft December 7, 2022 18:34
@b-butler
Copy link
Member Author

b-butler commented Dec 7, 2022

This needs to wait on HDF5 supporting Python 3.11.

@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #875 (50fa8c3) into master (cfe6b6f) will increase coverage by 0.76%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #875      +/-   ##
==========================================
+ Coverage   85.87%   86.64%   +0.76%     
==========================================
  Files          41       41              
  Lines        4575     4575              
  Branches      900      996      +96     
==========================================
+ Hits         3929     3964      +35     
+ Misses        465      431      -34     
+ Partials      181      180       -1     
Impacted Files Coverage Δ
signac/project.py 86.44% <0.00%> (+0.16%) ⬆️
signac/import_export.py 77.24% <0.00%> (+0.26%) ⬆️
signac/job.py 89.93% <0.00%> (+0.64%) ⬆️
signac/__main__.py 77.99% <0.00%> (+0.73%) ⬆️
...ac/_synced_collections/backends/collection_json.py 98.46% <0.00%> (+0.76%) ⬆️
signac/_dict_manager.py 88.37% <0.00%> (+2.32%) ⬆️
signac/_utility.py 100.00% <0.00%> (+4.44%) ⬆️
signac/_synced_collections/numpy_utils.py 100.00% <0.00%> (+12.00%) ⬆️
..._synced_collections/backends/collection_mongodb.py 90.90% <0.00%> (+40.90%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bdice
Copy link
Member

bdice commented Dec 7, 2022

An issue exists upstream in h5py: h5py/h5py#2146

It is possible for us to move forward without h5py, because it is an optional dependency. Note that we have the "minimal" tests passing.

@b-butler
Copy link
Member Author

b-butler commented Dec 7, 2022

True, I more just didn't want to have to revisit this when the wheels exist, and the PR serves as a reminder to check.

@bdice
Copy link
Member

bdice commented Jan 21, 2023

This has been waiting for an h5py release for over a month. In the interest of moving this PR forward, I am going to merge it. I created a follow-up issue with tasks for when h5py wheels exist for Python 3.11. #885

@bdice bdice marked this pull request as ready for review January 21, 2023 15:10
Copy link
Member

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this update! Further changes will be needed once h5py wheels are available, see #885.

@bdice bdice enabled auto-merge (squash) January 21, 2023 15:11
@bdice bdice merged commit 00d1d6c into master Jan 21, 2023
@bdice bdice deleted the add-python-3.11-support branch January 21, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants