-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Move all modules into root namespace. #862
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -28,6 +28,7 @@ repos: | |
- id: pyupgrade | ||
args: | ||
- --py38-plus | ||
exclude: '_vendor' | ||
- repo: https://github.com/PyCQA/isort | ||
rev: '5.10.1' | ||
hooks: | ||
|
@@ -40,6 +41,11 @@ repos: | |
rev: '4.0.1' | ||
hooks: | ||
- id: flake8 | ||
exclude: | | ||
(?x)^( | ||
^signac/_vendor/configobj/| | ||
^signac/_vendor/deprecation/| | ||
) | ||
- repo: https://github.com/PyCQA/pydocstyle | ||
rev: '6.1.1' | ||
hooks: | ||
|
@@ -48,8 +54,8 @@ repos: | |
(?x)^( | ||
^doc/| | ||
^tests/| | ||
^signac/common/configobj/| | ||
^signac/common/deprecation/| | ||
^signac/_vendor/configobj/| | ||
^signac/_vendor/deprecation/| | ||
^signac/db/ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can this line be removed? |
||
) | ||
- repo: https://github.com/pre-commit/mirrors-mypy | ||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -12,13 +12,13 @@ python-tag = py3 | |||||
|
||||||
[flake8] | ||||||
max-line-length = 100 | ||||||
exclude = configobj | ||||||
exclude = _vendor | ||||||
select = E,F,W | ||||||
ignore = E123,E126,E203,E226,E241,E704,W503,W504 | ||||||
|
||||||
[pydocstyle] | ||||||
match = ^((?!\.sync-zenodo-metadata|setup|benchmark).)*\.py$ | ||||||
match-dir = ^((?!\.|tests|configobj).)*$ | ||||||
match-dir = ^((?!\.|tests|_vendor).)*$ | ||||||
ignore-decorators = "deprecated" | ||||||
add-ignore = D105, D107, D203, D204, D213 | ||||||
|
||||||
|
@@ -31,7 +31,7 @@ concurrency = thread,multiprocessing | |||||
parallel = True | ||||||
source = signac | ||||||
omit = | ||||||
*/signac/common/configobj/*.py | ||||||
*/signac/_vendor/configobj/*.py | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we make this broader?
Suggested change
|
||||||
|
||||||
[tool:pytest] | ||||||
filterwarnings = | ||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,13 +29,8 @@ | |
else: | ||
READLINE = True | ||
|
||
from . import get_project, init_project | ||
from .common import config | ||
from .common.configobj import Section, flatten_errors | ||
from .contrib.filterparse import parse_filter_arg | ||
from .contrib.import_export import _SchemaPathEvaluationError, export_jobs | ||
from .contrib.utility import _add_verbosity_argument, _print_err, _query_yes_no | ||
from .core.utility import _safe_relpath | ||
from . import config, get_project, init_project | ||
from ._vendor.configobj import Section, flatten_errors | ||
from .diff import diff_jobs | ||
from .errors import ( | ||
DestinationExistsError, | ||
|
@@ -44,7 +39,10 @@ | |
SchemaSyncConflict, | ||
SyncConflict, | ||
) | ||
from .filterparse import parse_filter_arg | ||
from .import_export import _SchemaPathEvaluationError, export_jobs | ||
from .sync import DocSync, FileSync | ||
from .utility import _add_verbosity_argument, _print_err, _query_yes_no, _safe_relpath | ||
from .version import __version__ | ||
|
||
MSG_SYNC_SPECIFY_KEY = """ | ||
|
@@ -491,7 +489,7 @@ def _sig(st): | |
|
||
|
||
def _main_import_interactive(project, origin, args): | ||
from .contrib.import_export import _prepare_import_into_project | ||
from .import_export import _prepare_import_into_project | ||
|
||
if args.move: | ||
raise ValueError( | ||
|
@@ -534,7 +532,7 @@ def _main_import_interactive(project, origin, args): | |
|
||
|
||
def _main_import_non_interactive(project, origin, args): | ||
from .contrib.import_export import _prepare_import_into_project | ||
from .import_export import _prepare_import_into_project | ||
|
||
try: | ||
paths = {} | ||
|
@@ -637,7 +635,7 @@ def main_update_cache(args): | |
# UNCOMMENT THE FOLLOWING BLOCK WHEN THE FIRST MIGRATION IS INTRODUCED. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I just realized this PR is targeting |
||
# def main_migrate(args): | ||
# "Migrate the project's schema to the current schema version." | ||
# from .contrib.migration import apply_migrations, _get_config_schema_version | ||
# from .migration import apply_migrations, _get_config_schema_version | ||
# from packaging import version | ||
# from .version import SCHEMA_VERSION | ||
# project = get_project(_ignore_schema_version=True) | ||
|
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like this to use the same
(?x)^(
syntax as the other exclusions.