Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] Remove upper bound on python_requires #781

Conversation

matthewfeickert
Copy link
Contributor

@matthewfeickert matthewfeickert commented Jun 22, 2022

Description

Motivation and Context

This change follows best practices for libraries and frameworks as generally recommended by the PyPA.

Resolves #780

Checklist:

* Remove upper bound of Python 4 on python_requires as advocated for in Henry Schreiner's
blog post "Should You Use Upper Bound Version Constraints?". 
   - c.f. https://iscinumpy.dev/post/bound-version-constraints/
@matthewfeickert matthewfeickert requested review from a team as code owners June 22, 2022 05:25
@matthewfeickert matthewfeickert requested review from bdice and klywang and removed request for a team June 22, 2022 05:25
@bdice
Copy link
Member

bdice commented Jun 22, 2022

Note: the same thing should also be done for additional glotzerlab repositories.

signac-flow, signac-dashboard, rowan, gsd (uses ~=3.6 which would not match 4), garnett, hoomdpy-addons.

I can help with signac packages but leave the rest to other maintainers. cc: @b-butler @joaander @vyasr

Copy link
Contributor

@tommy-waltmann tommy-waltmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one quick comment.

changelog.txt Outdated Show resolved Hide resolved
@vyasr
Copy link
Contributor

vyasr commented Jun 22, 2022

@matthewfeickert thanks for the contribution!

@matthewfeickert matthewfeickert force-pushed the build/remove-upper-bound-on-python_requires branch from 4c11987 to 713dce0 Compare June 22, 2022 17:07
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again.

@vyasr vyasr merged commit bd8ad04 into glotzerlab:master Jun 22, 2022
@matthewfeickert matthewfeickert deleted the build/remove-upper-bound-on-python_requires branch June 22, 2022 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove upper bound on python_requires
4 participants