-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNT] Remove upper bound on python_requires #781
Merged
vyasr
merged 3 commits into
glotzerlab:master
from
matthewfeickert:build/remove-upper-bound-on-python_requires
Jun 22, 2022
Merged
[MNT] Remove upper bound on python_requires #781
vyasr
merged 3 commits into
glotzerlab:master
from
matthewfeickert:build/remove-upper-bound-on-python_requires
Jun 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove upper bound of Python 4 on python_requires as advocated for in Henry Schreiner's blog post "Should You Use Upper Bound Version Constraints?". - c.f. https://iscinumpy.dev/post/bound-version-constraints/
bdice
approved these changes
Jun 22, 2022
This was referenced Jun 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one quick comment.
@matthewfeickert thanks for the contribution! |
4c11987
to
713dce0
Compare
tommy-waltmann
approved these changes
Jun 22, 2022
vyasr
approved these changes
Jun 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
python_requires
as advocated for in Henry Schreiner's blog post "Should You Use Upper Bound Version Constraints?".Motivation and Context
This change follows best practices for libraries and frameworks as generally recommended by the PyPA.
Resolves #780
Checklist: