-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise errors for uncaught FutureWarnings / DeprecationWarnings in signac. #713
Conversation
Codecov Report
@@ Coverage Diff @@
## master #713 +/- ##
==========================================
- Coverage 78.34% 78.27% -0.07%
==========================================
Files 66 66
Lines 7231 7231
Branches 1586 1586
==========================================
- Hits 5665 5660 -5
- Misses 1251 1255 +4
- Partials 315 316 +1
Continue to review full report at Codecov.
|
8659688
to
4ce7625
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question, but looks good overall.
Description
To help ensure that all
DeprecationWarning
s are converted toFutureWarning
s, I updated our pytest configuration to treat warnings as errors. I added exceptions for all existing warnings.Merging this PR will help us identify all
DeprecationWarning
s that should be replaced byFutureWarning
s. We will remove all existing exceptions forDeprecationWarning
insetup.cfg
and the test files as they are converted toFutureWarning
.Motivation and Context
Aids with #687. This can be merged before #718 but it will require modifications to
setup.cfg
after that PR is merged.Checklist: