Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FutureWarning instead of DeprecationWarning. #692

Merged
merged 14 commits into from
Mar 12, 2022
Merged

Use FutureWarning instead of DeprecationWarning. #692

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
daded12
Update __init__.py
Onkar627 Feb 26, 2022
234c34e
Update indexing.py
Onkar627 Feb 26, 2022
c318473
Merge branch 'glotzerlab:master' into patch-3
Onkar627 Mar 8, 2022
d51ec0c
Update collection_json.py
Onkar627 Mar 8, 2022
acdd77a
Update file_buffered_collection.py
Onkar627 Mar 8, 2022
5acba78
Update __init__.py
Onkar627 Mar 8, 2022
fcd0a6f
Merge branch 'glotzerlab:master' into patch-3
Onkar627 Mar 11, 2022
3472222
Update file_buffered_collection.py
Onkar627 Mar 11, 2022
9dad3e8
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 11, 2022
57e0ccd
Update test_json_collection.py
Onkar627 Mar 11, 2022
55022f7
Update conftest.py
Onkar627 Mar 11, 2022
7cd1ea3
Removed deprecated_in_version function and use pytest.deprecated_call…
bdice Mar 12, 2022
ceacc11
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 12, 2022
578f22f
Remove unused imports.
bdice Mar 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion signac/contrib/indexing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,7 +620,7 @@ def __init__(self, *args, **kwargs):
warnings.warn(
"The MasterCrawler class has been replaced by the MainCrawler class. "
"Both classes are deprecated and will be removed in a future release.",
DeprecationWarning,
FutureWarning,
)
super().__init__(*args, **kwargs)

Expand Down
4 changes: 2 additions & 2 deletions signac/synced_collections/backends/collection_json.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def _str_key(key):
warnings.warn(
f"Use of {type(key).__name__} as key is deprecated "
"and will be removed in version 2.0",
DeprecationWarning,
FutureWarning,
)
key = str(key)
return key
Expand Down Expand Up @@ -146,7 +146,7 @@ def json_attr_dict_validator(data):
warnings.warn(
f"Use of {type(key).__name__} as key is deprecated "
"and will be removed in version 2.0.",
DeprecationWarning,
FutureWarning,
)
data[str(key)] = data.pop(key)
else:
Expand Down
2 changes: 1 addition & 1 deletion signac/synced_collections/buffers/file_buffered_collection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ def buffer_backend(cls, buffer_size=None, force_write=None, *args, **kwargs):
"""
if force_write is not None:
warnings.warn(
DeprecationWarning(
FutureWarning(
Copy link
Member

@bdice bdice Mar 9, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, something was wrong here in the old code. Can you switch this to call warnings.warn(message, FutureWarning) instead of warnings.warn(FutureWarning(message))? The function isn't being used correctly.

https://docs.python.org/3/library/warnings.html#warnings.warn

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, sure.

"The force_write parameter is deprecated and will be removed in "
"signac 2.0. This functionality is no longer supported."
)
Expand Down