Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove JobsCursor.next. #604

Merged
merged 1 commit into from
Aug 18, 2021
Merged

Remove JobsCursor.next. #604

merged 1 commit into from
Aug 18, 2021

Conversation

bdice
Copy link
Member

@bdice bdice commented Aug 17, 2021

Description

Removes the long-deprecated JobsCursor.next method (deprecated since before 1.0).

Motivation and Context

signac 2.0 API cleanup.

Types of Changes

  • Documentation update
  • Bug fix
  • New feature
  • Breaking change1

1The change breaks (or has the potential to break) existing functionality.

Checklist:

If necessary:

  • I have updated the API documentation as part of the package doc-strings.
  • I have created a separate pull request to update the framework documentation on signac-docs and linked it here.
  • I have updated the changelog and added all related issue and pull request numbers for future reference (if applicable). See example below.

@bdice bdice requested review from a team as code owners August 17, 2021 21:46
@bdice bdice requested review from vyasr and Charlottez112 August 17, 2021 21:46
@bdice bdice self-assigned this Aug 17, 2021
@bdice bdice added this to the v2.0.0 milestone Aug 17, 2021
@mikemhenry
Copy link
Collaborator

I think this is the oldest thing we have cut lately and I'm just waiting for this to show up on slack.
https://xkcd.com/1172/

@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #604 (03251c6) into next (a2cbd21) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             next     #604      +/-   ##
==========================================
- Coverage   85.77%   85.74%   -0.03%     
==========================================
  Files          52       52              
  Lines        5075     5066       -9     
  Branches      914      913       -1     
==========================================
- Hits         4353     4344       -9     
  Misses        522      522              
  Partials      200      200              
Impacted Files Coverage Δ
signac/contrib/project.py 88.13% <ø> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2cbd21...03251c6. Read the comment docs.

@bdice bdice merged commit 364345b into next Aug 18, 2021
@bdice bdice deleted the remove/JobsCursor-next branch August 18, 2021 22:09
vyasr pushed a commit that referenced this pull request Nov 9, 2021
bdice added a commit that referenced this pull request Dec 5, 2021
vyasr pushed a commit that referenced this pull request Dec 25, 2021
vyasr pushed a commit that referenced this pull request Jan 4, 2022
vyasr pushed a commit that referenced this pull request Jan 27, 2022
vyasr pushed a commit that referenced this pull request Feb 4, 2022
vyasr pushed a commit that referenced this pull request Feb 21, 2022
vyasr pushed a commit that referenced this pull request Feb 21, 2022
vyasr pushed a commit that referenced this pull request Mar 14, 2022
vyasr pushed a commit that referenced this pull request Apr 19, 2022
vyasr pushed a commit that referenced this pull request Apr 21, 2022
vyasr pushed a commit that referenced this pull request May 2, 2022
bdice added a commit that referenced this pull request Jun 14, 2022
bdice added a commit that referenced this pull request Aug 1, 2022
bdice added a commit that referenced this pull request Oct 7, 2022
bdice added a commit that referenced this pull request Oct 27, 2022
vyasr pushed a commit that referenced this pull request Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants