Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused functions. #598

Merged
merged 3 commits into from
Aug 6, 2021
Merged

Remove unused functions. #598

merged 3 commits into from
Aug 6, 2021

Conversation

bdice
Copy link
Member

@bdice bdice commented Aug 6, 2021

Description

A few smaller commits that I forgot to push to #597. I am going to merge this immediately since it's just removing private functions that are never called internally (I found them by looking over test coverage, and verified that the functions are never used).

Motivation and Context

signac 2.0 API cleanup.

@bdice bdice requested review from a team as code owners August 6, 2021 19:15
@bdice bdice requested review from vyasr and lyrivera August 6, 2021 19:15
@bdice bdice merged commit 579800d into next Aug 6, 2021
@bdice bdice deleted the cleanup-utility branch August 6, 2021 19:15
vyasr pushed a commit that referenced this pull request Nov 9, 2021
* Remove unused _get_branches function.

* Remove unused _flatten function.

* Define error message in one line.
bdice added a commit that referenced this pull request Dec 5, 2021
* Remove unused _get_branches function.

* Remove unused _flatten function.

* Define error message in one line.
vyasr pushed a commit that referenced this pull request Dec 25, 2021
* Remove unused _get_branches function.

* Remove unused _flatten function.

* Define error message in one line.
vyasr pushed a commit that referenced this pull request Jan 4, 2022
* Remove unused _get_branches function.

* Remove unused _flatten function.

* Define error message in one line.
vyasr pushed a commit that referenced this pull request Jan 27, 2022
* Remove unused _get_branches function.

* Remove unused _flatten function.

* Define error message in one line.
vyasr pushed a commit that referenced this pull request Feb 4, 2022
* Remove unused _get_branches function.

* Remove unused _flatten function.

* Define error message in one line.
vyasr pushed a commit that referenced this pull request Feb 21, 2022
* Remove unused _get_branches function.

* Remove unused _flatten function.

* Define error message in one line.
vyasr pushed a commit that referenced this pull request Feb 21, 2022
* Remove unused _get_branches function.

* Remove unused _flatten function.

* Define error message in one line.
vyasr pushed a commit that referenced this pull request Mar 14, 2022
* Remove unused _get_branches function.

* Remove unused _flatten function.

* Define error message in one line.
vyasr pushed a commit that referenced this pull request Apr 19, 2022
* Remove unused _get_branches function.

* Remove unused _flatten function.

* Define error message in one line.
vyasr pushed a commit that referenced this pull request Apr 21, 2022
* Remove unused _get_branches function.

* Remove unused _flatten function.

* Define error message in one line.
vyasr pushed a commit that referenced this pull request May 2, 2022
* Remove unused _get_branches function.

* Remove unused _flatten function.

* Define error message in one line.
bdice added a commit that referenced this pull request Jun 14, 2022
* Remove unused _get_branches function.

* Remove unused _flatten function.

* Define error message in one line.
bdice added a commit that referenced this pull request Aug 1, 2022
* Remove unused _get_branches function.

* Remove unused _flatten function.

* Define error message in one line.
@b-butler b-butler added this to the v1.8.0 milestone Sep 19, 2022
bdice added a commit that referenced this pull request Oct 7, 2022
* Remove unused _get_branches function.

* Remove unused _flatten function.

* Define error message in one line.
bdice added a commit that referenced this pull request Oct 27, 2022
* Remove unused _get_branches function.

* Remove unused _flatten function.

* Define error message in one line.
vyasr pushed a commit that referenced this pull request Oct 30, 2022
* Remove unused _get_branches function.

* Remove unused _flatten function.

* Define error message in one line.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants