Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused error classes. #595

Merged
merged 2 commits into from
Aug 9, 2021
Merged

Remove unused error classes. #595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b10a2c7
Remove unused error classes.
bdice Aug 6, 2021
e0b9217
Remove AuthenticationError, ExportError, FetchError.
bdice Aug 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions signac/common/errors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,28 +9,3 @@ class ConfigError(Error, RuntimeError):
"""Error with parsing or reading a configuration file."""

pass


# this class is only used by deprecated features
class AuthenticationError(Error, RuntimeError):
"""Authentication error."""

def __str__(self):
if len(self.args) > 0:
return f"Failed to authenticate with host '{self.args[0]}'."
else:
return "Failed to authenticate with host."


# this class is only used by deprecated features
class ExportError(Error, RuntimeError):
"""Error exporting documents to a mirror."""

pass


# this class is only used by deprecated features
class FetchError(FileNotFoundError):
"""Error in fetching data."""

pass
5 changes: 1 addition & 4 deletions signac/errors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
# exceptions that are relevant beyond a single module. This top-level errors
# module is used to expose user-facing exception classes.

from .common.errors import AuthenticationError, ConfigError, ExportError, FetchError
from .common.errors import ConfigError
from .contrib.errors import (
DestinationExistsError,
IncompatibleSchemaVersion,
Expand Down Expand Up @@ -59,13 +59,10 @@ def __str__(self):


__all__ = [
"AuthenticationError",
"ConfigError",
"DestinationExistsError",
"DocumentSyncConflict",
"Error",
"ExportError",
"FetchError",
"FileSyncConflict",
"IncompatibleSchemaVersion",
"InvalidKeyError",
Expand Down