-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove cite submodule. #594
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #594 +/- ##
==========================================
+ Coverage 83.77% 83.91% +0.13%
==========================================
Files 54 53 -1
Lines 5535 5519 -16
Branches 1021 1017 -4
==========================================
- Hits 4637 4631 -6
+ Misses 668 658 -10
Partials 230 230
Continue to review full report at Codecov.
|
csadorf
approved these changes
Aug 6, 2021
vyasr
pushed a commit
that referenced
this pull request
Nov 9, 2021
bdice
added a commit
that referenced
this pull request
Dec 5, 2021
vyasr
pushed a commit
that referenced
this pull request
Dec 25, 2021
vyasr
pushed a commit
that referenced
this pull request
Jan 4, 2022
vyasr
pushed a commit
that referenced
this pull request
Jan 27, 2022
vyasr
pushed a commit
that referenced
this pull request
Feb 4, 2022
vyasr
pushed a commit
that referenced
this pull request
Feb 21, 2022
vyasr
pushed a commit
that referenced
this pull request
Feb 21, 2022
vyasr
pushed a commit
that referenced
this pull request
Mar 14, 2022
vyasr
pushed a commit
that referenced
this pull request
Apr 19, 2022
vyasr
pushed a commit
that referenced
this pull request
Apr 21, 2022
vyasr
pushed a commit
that referenced
this pull request
May 2, 2022
bdice
added a commit
that referenced
this pull request
Jun 14, 2022
bdice
added a commit
that referenced
this pull request
Aug 1, 2022
bdice
added a commit
that referenced
this pull request
Oct 7, 2022
bdice
added a commit
that referenced
this pull request
Oct 27, 2022
vyasr
pushed a commit
that referenced
this pull request
Oct 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is my suggestion for resolving #592 (I chose to remove it -- but we could update that submodule instead, if desired).
Deprecation of the submodule in 1.x is still needed to fully resolve #592.
Motivation and Context
API cleanup.
Types of Changes
1The change breaks (or has the potential to break) existing functionality.
Checklist:
If necessary: