Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cite submodule. #594

Merged
merged 1 commit into from
Aug 6, 2021
Merged

Remove cite submodule. #594

merged 1 commit into from
Aug 6, 2021

Conversation

bdice
Copy link
Member

@bdice bdice commented Aug 6, 2021

Description

This PR is my suggestion for resolving #592 (I chose to remove it -- but we could update that submodule instead, if desired).

Deprecation of the submodule in 1.x is still needed to fully resolve #592.

Motivation and Context

API cleanup.

Types of Changes

  • Documentation update
  • Bug fix
  • New feature
  • Breaking change1

1The change breaks (or has the potential to break) existing functionality.

Checklist:

If necessary:

  • I have updated the API documentation as part of the package doc-strings.
  • I have created a separate pull request to update the framework documentation on signac-docs and linked it here.
  • I have updated the changelog and added all related issue and pull request numbers for future reference (if applicable). See example below.

@bdice bdice requested review from a team as code owners August 6, 2021 04:51
@bdice bdice requested review from atravitz and Charlottez112 August 6, 2021 04:51
@bdice bdice mentioned this pull request Aug 6, 2021
5 tasks
@bdice bdice added the requires-1.x-deprecation Changes for 2.0 that require a deprecation to be added in 1.x. label Aug 6, 2021
@bdice bdice added this to the v2.0.0 milestone Aug 6, 2021
@bdice bdice self-assigned this Aug 6, 2021
@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #594 (981d99d) into next (257c931) will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next     #594      +/-   ##
==========================================
+ Coverage   83.77%   83.91%   +0.13%     
==========================================
  Files          54       53       -1     
  Lines        5535     5519      -16     
  Branches     1021     1017       -4     
==========================================
- Hits         4637     4631       -6     
+ Misses        668      658      -10     
  Partials      230      230              
Impacted Files Coverage Δ
signac/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 257c931...981d99d. Read the comment docs.

@bdice bdice merged commit e2596b4 into next Aug 6, 2021
@bdice bdice deleted the remove-cite branch August 6, 2021 16:22
vyasr pushed a commit that referenced this pull request Nov 9, 2021
bdice added a commit that referenced this pull request Dec 5, 2021
vyasr pushed a commit that referenced this pull request Dec 25, 2021
vyasr pushed a commit that referenced this pull request Jan 4, 2022
vyasr pushed a commit that referenced this pull request Jan 27, 2022
vyasr pushed a commit that referenced this pull request Feb 4, 2022
vyasr pushed a commit that referenced this pull request Feb 21, 2022
vyasr pushed a commit that referenced this pull request Feb 21, 2022
vyasr pushed a commit that referenced this pull request Mar 14, 2022
vyasr pushed a commit that referenced this pull request Apr 19, 2022
vyasr pushed a commit that referenced this pull request Apr 21, 2022
vyasr pushed a commit that referenced this pull request May 2, 2022
bdice added a commit that referenced this pull request Jun 14, 2022
bdice added a commit that referenced this pull request Aug 1, 2022
bdice added a commit that referenced this pull request Oct 7, 2022
bdice added a commit that referenced this pull request Oct 27, 2022
vyasr pushed a commit that referenced this pull request Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requires-1.x-deprecation Changes for 2.0 that require a deprecation to be added in 1.x.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants