Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise DestinationExistsError from EEXIST. #433

Merged
merged 5 commits into from
Dec 16, 2020
Merged

Raise DestinationExistsError from EEXIST. #433

merged 5 commits into from
Dec 16, 2020

Conversation

bdice
Copy link
Member

@bdice bdice commented Dec 14, 2020

Description

This should fix some intermittent failures seen on CI. It may need to be run on CI a few times to ensure that this fixes the problem.

See issue #431 for a full description of the issue this aims to resolve.

Motivation and Context

Fix CI failures relating to POSIX error code handling.

Types of Changes

  • Documentation update
  • Bug fix
  • New feature
  • Breaking change1

1The change breaks (or has the potential to break) existing functionality.

Checklist:

If necessary:

  • I have updated the API documentation as part of the package doc-strings.
  • I have created a separate pull request to update the framework documentation on signac-docs and linked it here.
  • I have updated the changelog and added all related issue and pull request numbers for future reference (if applicable). See example below.

@bdice bdice requested review from a team as code owners December 14, 2020 06:59
@bdice bdice requested review from csadorf and pepak13 and removed request for a team December 14, 2020 06:59
@codecov
Copy link

codecov bot commented Dec 14, 2020

Codecov Report

Merging #433 (4e8681e) into master (648760d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #433   +/-   ##
=======================================
  Coverage   76.59%   76.59%           
=======================================
  Files          45       45           
  Lines        7079     7079           
=======================================
  Hits         5422     5422           
  Misses       1657     1657           
Impacted Files Coverage Δ
signac/contrib/import_export.py 85.44% <100.00%> (ø)
signac/contrib/job.py 92.80% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dfe629...96fa784. Read the comment docs.

@atravitz
Copy link
Collaborator

This looks good, we should merge before #429. Do we need to run CI a few more times first?

@atravitz atravitz self-requested a review December 16, 2020 19:53
@klywang klywang self-requested a review December 16, 2020 20:25
@klywang
Copy link
Contributor

klywang commented Dec 16, 2020

Looks good!

@atravitz I think it would be a good idea to run CI a few more times, just to be safe.

@bdice
Copy link
Member Author

bdice commented Dec 16, 2020

I'm happy with the level of success on this PR, it ran without any failures for at least 4 test commits. We would expect to see failures by this point if the problem hadn't been solved. I'm going to go ahead and merge this to prevent further CI failures on other PRs.

@bdice bdice added the bug Something isn't working label Dec 16, 2020
@bdice bdice self-assigned this Dec 16, 2020
@bdice bdice added this to the v1.5.1 milestone Dec 16, 2020
@bdice bdice merged commit 7db7d57 into master Dec 16, 2020
@bdice bdice deleted the fix/ignore-eexist branch December 16, 2020 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants