-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise DestinationExistsError from EEXIST. #433
Conversation
…tionExistsError (related to #431).
Codecov Report
@@ Coverage Diff @@
## master #433 +/- ##
=======================================
Coverage 76.59% 76.59%
=======================================
Files 45 45
Lines 7079 7079
=======================================
Hits 5422 5422
Misses 1657 1657
Continue to review full report at Codecov.
|
This looks good, we should merge before #429. Do we need to run CI a few more times first? |
Looks good! @atravitz I think it would be a good idea to run CI a few more times, just to be safe. |
I'm happy with the level of success on this PR, it ran without any failures for at least 4 test commits. We would expect to see failures by this point if the problem hadn't been solved. I'm going to go ahead and merge this to prevent further CI failures on other PRs. |
Description
This should fix some intermittent failures seen on CI. It may need to be run on CI a few times to ensure that this fixes the problem.
See issue #431 for a full description of the issue this aims to resolve.
Motivation and Context
Fix CI failures relating to POSIX error code handling.
Types of Changes
1The change breaks (or has the potential to break) existing functionality.
Checklist:
If necessary: