Throw descriptive error message for linked views on Windows. #236

bdice · 2019-10-25T02:54:56Z

Description

Added an error message that is raised on Windows when attempting to create a linked view.

Resolves #214.

¹The change breaks (or has the potential to break) existing functionality.

I am familiar with the Contributing Guidelines.
I agree with the terms of the Contributor Agreement.
My name is on the list of contributors.
My code follows the code style guideline of this project.
The changes introduced by this pull request are covered by existing or newly introduced tests.

If necessary:

I have updated the API documentation as part of the package doc-strings.
I have created a separate pull request to update the framework documentation on signac-docs and linked it here.
I have updated the changelog.

…on Windows.

csadorf · 2019-10-29T07:51:23Z

I'm kind of tired of the PyPy3 tests always randomly failing in combination with h5py. @mikemhenry Didn't we try to address that at some point?

csadorf · 2019-10-29T07:52:02Z

@bdice LGTM! Feel free to squash and merge with admin override.

…lab#236) * Throw descriptive error message when attempting to make linked views on Windows. * Add changelog message.

bdice added 2 commits October 24, 2019 22:51

Throw descriptive error message when attempting to make linked views …

ac988de

…on Windows.

Add changelog message.

dadfa8b

bdice requested review from csadorf and a team as code owners October 25, 2019 02:54

ghost removed their request for review October 25, 2019 02:55

bdice self-assigned this Oct 25, 2019

bdice requested review from a team and removed request for csadorf October 25, 2019 02:55

ghost requested review from csadorf and removed request for a team October 25, 2019 02:55

csadorf approved these changes Oct 29, 2019

View reviewed changes

bdice merged commit 6a969db into master Oct 29, 2019

bdice deleted the fix/issue-214 branch October 29, 2019 15:12