Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make lists containing dicts hashable. #218

Merged
merged 1 commit into from
Aug 9, 2019
Merged

Make lists containing dicts hashable. #218

merged 1 commit into from
Aug 9, 2019

Conversation

csadorf
Copy link
Contributor

@csadorf csadorf commented Aug 9, 2019

Fixes issue #217.

@csadorf csadorf requested a review from a team as a code owner August 9, 2019 14:56
@csadorf csadorf requested a review from vyasr August 9, 2019 14:57
bdice
bdice approved these changes Aug 9, 2019
View reviewed changes
Copy link
Member

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@codecov
Copy link

codecov bot commented Aug 9, 2019

Codecov Report

Merging #218 into master will increase coverage by 0.03%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #218      +/-   ##
==========================================
+ Coverage   65.12%   65.15%   +0.03%     
==========================================
  Files          37       37              
  Lines        5594     5599       +5     
==========================================
+ Hits         3643     3648       +5     
  Misses       1951     1951
Impacted Files Coverage Δ
signac/contrib/collection.py 88.76% <90%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b100fc0...818e2dd. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Aug 9, 2019 •
edited
Loading

Codecov Report

Merging #218 into master will increase coverage by 0.03%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #218      +/-   ##
==========================================
+ Coverage   65.12%   65.15%   +0.03%     
==========================================
  Files          37       37              
  Lines        5594     5599       +5     
==========================================
+ Hits         3643     3648       +5     
  Misses       1951     1951
Impacted Files Coverage Δ
signac/contrib/collection.py 88.76% <90%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b100fc0...818e2dd. Read the comment docs.

@csadorf csadorf merged commit add19c3 into master Aug 9, 2019
@csadorf csadorf deleted the fix/issue-217 branch August 9, 2019 18:25
@bdice bdice mentioned this pull request Nov 30, 2020
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@bdice bdice bdice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@csadorf @vyasr @bdice