-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add function to initialize a test workspace #215
Conversation
Codecov Report
@@ Coverage Diff @@
## master #215 +/- ##
==========================================
+ Coverage 65.15% 65.25% +0.09%
==========================================
Files 37 38 +1
Lines 5599 5615 +16
==========================================
+ Hits 3648 3664 +16
Misses 1951 1951
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to add a few unit tests and then this is ready to ship.
@tcmoore3 I've added a few comments with suggestions to keep track of things. I'm happy to take those on myself unless you want to do that. Just let me know. |
Changes to address comments in PR #215
@csadorf Cool. I made the suggested changes. Did you already write unit tests? I didn't see them on the branch. |
No, I didn't get to it. Maybe you or someone else could write them? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to extend the unit test just a little bit prior to merging, otherwise this is all good.
Returning the jobs makes more sense, because we already have a reference to the project and this makes it easier to delete those jobs again.
I am going to try to fix issue #217 before merging this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is related to signac-flow issue glotzerlab/signac-flow#130 and glotzerlab/signac-flow#129, where we decided it makes more sense to break up the data space initialization into signac core and the flow project initialization into flow.
Types of Changes
Checklist:
If necessary: