Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Python 3.8+. #628

Merged
merged 7 commits into from
Mar 22, 2022
Merged

Require Python 3.8+. #628

merged 7 commits into from
Mar 22, 2022

Conversation

bdice
Copy link
Member

@bdice bdice commented Mar 20, 2022

Description

NEP 29 has dropped support for Python < 3.8. This PR updates signac-flow to require Python 3.8+.

See also glotzerlab/signac#715.

I also updated our Jinja requirement to 3.0.0. Older versions of Jinja are incompatible with the latest version of markupsafe, one of Jinja’s dependencies. Requiring Jinja 3.0.0+ fixes this, and allows us to drop some compatibility code.

Checklist:

@bdice bdice requested review from a team as code owners March 20, 2022 22:28
@bdice bdice requested review from atravitz and syjlee and removed request for a team March 20, 2022 22:28
@bdice bdice self-assigned this Mar 20, 2022
@bdice bdice added the enhancement New feature or request label Mar 20, 2022
@bdice bdice added this to the v0.19.0 milestone Mar 20, 2022
@codecov
Copy link

codecov bot commented Mar 20, 2022

Codecov Report

Merging #628 (5d95deb) into master (0ee68b1) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #628      +/-   ##
==========================================
+ Coverage   79.20%   79.29%   +0.09%     
==========================================
  Files          33       33              
  Lines        3231     3227       -4     
  Branches      688      686       -2     
==========================================
  Hits         2559     2559              
+ Misses        529      527       -2     
+ Partials      143      141       -2     
Impacted Files Coverage Δ
flow/project.py 81.63% <100.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ee68b1...5d95deb. Read the comment docs.

Copy link
Contributor

@csadorf csadorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

changelog.txt Outdated Show resolved Hide resolved
Co-authored-by: Carl Simon Adorf <[email protected]>
@bdice bdice enabled auto-merge (squash) March 22, 2022 05:36
@bdice bdice merged commit 9e0b7cb into master Mar 22, 2022
@bdice bdice deleted the python38 branch March 22, 2022 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants