-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require Python 3.8+. #628
Require Python 3.8+. #628
Conversation
Codecov Report
@@ Coverage Diff @@
## master #628 +/- ##
==========================================
+ Coverage 79.20% 79.29% +0.09%
==========================================
Files 33 33
Lines 3231 3227 -4
Branches 688 686 -2
==========================================
Hits 2559 2559
+ Misses 529 527 -2
+ Partials 143 141 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Co-authored-by: Carl Simon Adorf <[email protected]>
Description
NEP 29 has dropped support for Python < 3.8. This PR updates signac-flow to require Python 3.8+.
See also glotzerlab/signac#715.
I also updated our Jinja requirement to 3.0.0. Older versions of Jinja are incompatible with the latest version of markupsafe, one of Jinja’s dependencies. Requiring Jinja 3.0.0+ fixes this, and allows us to drop some compatibility code.
Checklist: