Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI due to subtests -- pytest incompatibility #330

Merged
merged 1 commit into from
Jul 29, 2020
Merged

Conversation

b-butler
Copy link
Member

Description

Fixes CI tests from pytest >= 6.0 and pytest-subtest incompatibility see
pytest-dev/pytest-subtests#31.

Motivation and Context

It is nice not to have broken CI

Types of Changes

  • Documentation update
  • Bug fix
  • New feature
  • Breaking change1

1The change breaks (or has the potential to break) existing functionality.

Checklist:

If necessary:

  • I have updated the API documentation as part of the package doc-strings.
  • I have created a separate pull request to update the framework documentation on signac-docs and linked it here.
  • I have updated the changelog.

Our CI broken due to incompatibility with pytest-subtests and pytests v.6
@b-butler b-butler requested review from a team as code owners July 29, 2020 14:54
@b-butler b-butler requested review from zhou-pj and jennyfothergill and removed request for a team July 29, 2020 14:54
Copy link
Member

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks for the quick fix. We'll want to think about removing pytest-subtests in the future since its development tends to lag pytest and seems to break often.

Copy link
Collaborator

@mikemhenry mikemhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikemhenry mikemhenry merged commit 1a45285 into master Jul 29, 2020
@mikemhenry mikemhenry deleted the fix-ci-tests branch July 29, 2020 17:18
@csadorf
Copy link
Contributor

csadorf commented Jul 30, 2020

All of our test requirements should be fully pinned.

@bdice
Copy link
Member

bdice commented Aug 2, 2020

@csadorf I agree, we should have a specific version pinning. I have raised issue #332 to address that, and document our plan to remove pytest-subtests.

@bdice bdice added this to the v0.11.0 milestone Aug 12, 2020
kidrahahjo pushed a commit that referenced this pull request Aug 12, 2020
Our CI broken due to incompatibility with pytest-subtests and pytests v.6
kidrahahjo pushed a commit that referenced this pull request Sep 1, 2020
Our CI broken due to incompatibility with pytest-subtests and pytests v.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants