Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove docs about indexing #152

Merged
merged 7 commits into from
Oct 9, 2021
Merged

Remove docs about indexing #152

merged 7 commits into from
Oct 9, 2021

Conversation

cbkerr
Copy link
Member

@cbkerr cbkerr commented Aug 9, 2021

Description

Removing docs about indexing since it's deprecated.

Motivation and Context

See glotzerlab/signac#588

Checklist:

@vyasr
Copy link
Contributor

vyasr commented Sep 29, 2021

@atravitz @cbkerr any plans to move this forward?

@bdice bdice marked this pull request as ready for review October 9, 2021 23:37
@bdice bdice requested review from a team as code owners October 9, 2021 23:37
@bdice bdice requested review from pepak13 and removed request for a team October 9, 2021 23:37
@bdice
Copy link
Member

bdice commented Oct 9, 2021

@cbkerr @atravitz @vyasr I was looking at glotzerlab/signac#588 and realized that this PR solves most of the remaining work there. I think this PR looks good and will approve after a final review and checking the ReadTheDocs builds. I applied some minor changes but I don't think this needs further review since it's just a removal of the deprecated feature plus minor edits. In the interest of not stalling the work any further, I'm going to merge it soon -- we can revise anything else in later PRs if needed.

Copy link
Member

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your work on this @cbkerr! I updated the signac-examples repo to remove indexing references. I'll merge this after verifying that ReadTheDocs builds look correct.

@bdice bdice merged commit dc19ef1 into master Oct 9, 2021
@bdice bdice deleted the remove-indexing branch October 9, 2021 23:52
@bdice bdice mentioned this pull request Mar 11, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants