Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where disabled modules don't appear in the module list. #134

Merged
merged 2 commits into from
May 18, 2022
Merged

Fix bug where disabled modules don't appear in the module list. #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29858ba
Fix bug where disabled modules don't appear in the module list.
bdice May 17, 2022
c3a919a
Update changelog.
bdice May 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ Fixed
+++++

- Hide the list and grid view buttons when viewing a single job (#92, #110).
- Fixed bug with disabled modules not showing a checkbox to enable them in the grid view (#134).

Version 0.2
===========
Expand Down
2 changes: 1 addition & 1 deletion signac_dashboard/dashboard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ def keyfunc(module):
grouped = groupby(sorted(self.modules, key=keyfunc), key=keyfunc)
modules_by_context = {}
for context_key, context_group in grouped:
modules_by_context[context_key] = [m for m in context_group if m.enabled]
modules_by_context[context_key] = [m for m in context_group]
self._modules_by_context = modules_by_context

def _create_app(self, config={}):
Expand Down