Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Python 3.8+, update CI. #120

Merged
merged 7 commits into from
Mar 21, 2022
Merged

Require Python 3.8+, update CI. #120

merged 7 commits into from
Mar 21, 2022

Conversation

bdice
Copy link
Member

@bdice bdice commented Mar 20, 2022

Description

NEP 29 has dropped support for Python < 3.8. This PR updates signac-dashboard to require Python 3.8+.

See also related changes in glotzerlab/signac#715

Checklist:

If necessary:

  • I have updated the API documentation as part of the package doc-strings.
  • I have created a separate pull request to update the framework documentation on signac-docs and linked it here.
  • I have updated the changelog.

@bdice bdice requested a review from a team as a code owner March 20, 2022 22:06
@bdice bdice enabled auto-merge (squash) March 20, 2022 22:14
@codecov
Copy link

codecov bot commented Mar 20, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.36%. Comparing base (310a0ca) to head (d725f82).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #120   +/-   ##
=======================================
  Coverage   63.36%   63.36%           
=======================================
  Files          18       18           
  Lines         666      666           
=======================================
  Hits          422      422           
  Misses        244      244           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@csadorf csadorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bdice bdice merged commit eacfa08 into master Mar 21, 2022
@bdice bdice deleted the update-ci branch March 21, 2022 08:30
javierbg pushed a commit to javierbg/signac-dashboard that referenced this pull request Nov 28, 2022
* Update CI.

* Require Python 3.8+.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update PR template.

* Fix executor.

* Fix job name.

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants