Allow passing slice pointer as an interface pointer to Iter.All

[nadiamoe]

Sometimes we might encounter an scenario where the result holder used in Iter.All() is an slice passed down as an interface. For example:

func Fetch(path string, dest interface{}) {
	db.C(path).Find(nil).All(&dest)
}

func main() {
	// [...]
	Fetch("mycollection", make([]MyStruct, 0, 0))
}

In this scenario, mgo panics because dest is not a slice pointer. It actually is, but it's hidden as it is passed down as interface{} from Fetch(). We can simply check if the type behind the pointer is an interface, and if it is, just extract it again. That's what this patch does.

P.S.: Seems like gofmt also did some minor changes here and there, I hope you don't mind them.

[domodwyer]

Hi @roobre

Sounds like a good addition - can you add a test case that covers this behaviour? Also it seems changing the error message has broken the tests.

Dom

[nadiamoe]

Woops, certainly didn't expect that.

I'll restore the log message for the original error and add cases for the new, hopefully this afternoon

[domodwyer]

Thanks, that's awesome!

Dom

[szank]

Nice work :)

[domodwyer]

Ah sorry, would you mind targeting the development branch?

We'll merge after, looks great!

Dom

[nadiamoe]

Should I move the commits to the development branch or are you okay with merging master into develop?

[nadiamoe]

Seems like some test timed out on MONGODB=x86_64-ubuntu1404-3.4.10.

[domodwyer]

Sorry yes, the tests are a bit flakey.

Thanks @roobre - really appreciate you taking the time to open a PR! I'll merge when the test is finished :)

Dom

[nadiamoe]

No prob, thanks to you all for taking the time and effort of maintaining this project :D