Add value method to ICapturedArguments.
#832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
chancancode
approved these changes
Jun 19, 2018
|
@rwjblue you need to update the Checker<> type with this change. |
This seems to have been an oversight (likely hasn't mattered to date?), both `ICapturedNamedArguments` and `ICapturedPositionalArguments` already support `.value()`. This brings `ICapturedArguments` in line.
rwjblue
force-pushed
the
add-arguments-value
branch
from
8681a4e to
14f05d4
Compare
|
Updated to make the checker pass, and pinged @chancancode and @krisselden for review. If there is a better way, I'm happy to iterate... |
|
seems fine to me. not directly related, but we used to do more hand-crafted tuning for the empty cases because we believed them to be common (e.g. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to have been an oversight (likely hasn't mattered to date?), both
ICapturedNamedArgumentsandICapturedPositionalArgumentsalready support.value(). This bringsICapturedArgumentsin line.Supports changes in emberjs/ember.js#16747.