Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove assertion for now #515

Merged
merged 1 commit into from
May 25, 2017
Merged

remove assertion for now #515

merged 1 commit into from
May 25, 2017

Conversation

stefanpenner
Copy link
Contributor

@stefanpenner stefanpenner requested a review from rwjblue May 25, 2017 19:09
@rwjblue
Copy link
Member

rwjblue commented May 25, 2017

The build is failing due to pre-existing type errors. I suggest that we merge and manually release 😭.

Any objections?

@stefanpenner
Copy link
Contributor Author

Any objections?

no objections... unless @tomdale wants to fix :trollface:

@stefanpenner stefanpenner merged commit f1eec72 into release-0-22 May 25, 2017
@stefanpenner
Copy link
Contributor Author

I'll go manually edit the tarball for release

@stefanpenner
Copy link
Contributor Author

stefanpenner commented May 25, 2017 •
edited
Loading

@rwjblue http://static.iamstef.net/glimmer-vm/package.tgz should be the tweaked package.tgz But requires someone else to sanity check me. I left an empty line to try and preserve source maps.

@stefanpenner stefanpenner deleted the release-0-22-hotfix branch May 25, 2017 20:01
@rwjblue
Copy link
Member

rwjblue commented May 25, 2017

@stefanpenner the package.json version of that tarball is 0.23.0-alpha.1, but I would expect it to be 0.22.2. Did you start from the 0.22.1 tarball or 0.23.0-alpha.1?

@stefanpenner
Copy link
Contributor Author

good call, updating

@stefanpenner
Copy link
Contributor Author

I just mutated this one ->npm info glimmer-engine --json | jq -r '.dist.tarball' i should grab something else.

@stefanpenner
Copy link
Contributor Author

http://static.iamstef.net/glimmer-runtime/package.tgz is the right thing now I believe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefanpenner @rwjblue @Turbo87