Compile away local debug for publish #1494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
commented
Nov 14, 2023
| export const LOCAL_DEBUG: true | false = | ||
| import.meta.env.DEV && | ||
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-ignore |
There was a problem hiding this comment.
I didn't know how to best extend the meta.env type here, so I ignored it for now since it's compiled away during publish, and only used in this one file.
chancancode
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until our primary consumer of the VM natively supports import.meta.env and can incrementally opt in to features via that macro system, we must compile away certain things as they were before in 0.84.x and prior.
Instead of compiling away all DEV to false (which would hide a bunch of info from ember), i made a new flag
Here is evidence of the local debug stuff being compiled away:
(top: compiled, buttom: source)