Skip checking the source for synthetic attributes to prevent warning. #1431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backspace
added a commit
to cardstack/boxel
that referenced
this pull request
Jun 15, 2023
This is a patch to approximate this PR: glimmerjs/glimmer-vm#1431
backspace
added a commit
to cardstack/boxel
that referenced
this pull request
Jun 15, 2023
This is a patch to approximate this PR: glimmerjs/glimmer-vm#1431
|
I've been helping a client with some upgrades recently and found this message went away once the app was upgraded to 5.12. Probably can close now? You can see that other folks handled this by patching temporarily using |
|
Might want to leave this open based on this comment: #1430 (comment) |
|
@navels thanks, will do |
chancancode
added a commit
that referenced
this pull request
Feb 21, 2025
Re-apply #1430 with a more robust implementation and tests Also turns the warning into a `localAssert()` so it gets stripped before reaching downstream consumers. This relates to #1431 in that this removes the warning, so to the extent that #1431 was motivated by sliencing the warning in Ember builds, it avoids the issue. But I haven't investigated the root cause of that issue and whether it is indicative of an actual bug somewhere deeper. Fixes emberjs/ember.js#19392 Co-authored-by: Lee Nave <[email protected]>
chancancode
added a commit
that referenced
this pull request
Feb 21, 2025
Re-apply #1430 with a more robust implementation and tests Also turns the warning into a `localAssert()` so it gets stripped before reaching downstream consumers. This relates to #1431 in that this removes the warning, so to the extent that #1431 was motivated by sliencing the warning in Ember builds, it avoids the issue. But I haven't investigated the root cause of that issue and whether it is indicative of an actual bug somewhere deeper. Fixes emberjs/ember.js#19392 Co-authored-by: Lee Nave <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a warning caused when template parsing encounters a synthetic attribute (i.e., inserted by a plugin). For example, building the
ember-maybe-in-elementaddon outputs these warnings:and the same will happen for any app that uses the
ember-basic-dropdownaddon (which uses the above addon).These should fix the remaining causes of emberjs/ember.js#19392 that are not already fixed by #1430.
I tried to add a test that would be even vaguely useful and couldn't really come up with anything.