Add a DEFAULT_HELPER_MANAGER feature flag
#1384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windvis
commented
Mar 12, 2022
packages/@glimmer/integration-tests/test/managers/helper-manager-test.ts
Outdated
Show resolved
Hide resolved
Windvis
force-pushed
the
chore/default-helper-manager-feature-flag
branch
2 times, most recently
from
324c741 to
eb0a4b2
Compare
Windvis
commented
Mar 13, 2022
Windvis
commented
Mar 13, 2022
Windvis
force-pushed
the
chore/default-helper-manager-feature-flag
branch
from
eb0a4b2 to
47282b0
Compare
chancancode
reviewed
Mar 13, 2022
chancancode
reviewed
Mar 13, 2022
chancancode
reviewed
Mar 13, 2022
chancancode
reviewed
Mar 13, 2022
Windvis
force-pushed
the
chore/default-helper-manager-feature-flag
branch
from
47282b0 to
d1734cd
Compare
|
@chancancode Thanks for the quick review! I've pushed the requested changes 👍. |
chancancode
approved these changes
Mar 15, 2022
|
Thank you! Released as 0.84.1! |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I gave adding a feature flag a shot based on the information in #1383. I went for a similar approach as the Ember feature flagging system (albeit a bit simpler). Let me know if I should do things differently!
Closes #1383