[BUGFIX] Ensure owner is available during resolution for all components #1263
Conversation
pzuraq
force-pushed
the
pass-owner-to-all-component-definitions
branch
from
09a2729 to
609c3cd
Compare
| @@ -81,6 +169,34 @@ class OwnerTest extends RenderTest { | |||
|
|
|||
| assert.verifySteps(['foo-bar owner called', 'foo-baz owner called'], 'owners used correctly'); | |||
| } | |||
|
|
|||
| @test | |||
| 'owner can be changed by a component with the hasSubOwner capability'(assert: Assert) { | |||
There was a problem hiding this comment.
This test is unrelated, I just realized we didn't have it (or at least not an obvious one for it) so wanted to add it
There was a problem hiding this comment.
Can you add a test that passes a closure component into the model property of the mount and invoke that component inside of the mount with a yield block that invokes a component coming from the mount?
{{mount 'engine' model=MyComponent}}
inside the mounted
{{#let @model as |OuterComponent|}}
<OuterComponent>
<InnerComponent/>
</OuterComponent>
{{/let}}
I want to ensure you didn't conflate the owner (realm) concept with dynamic scope.
pzuraq
force-pushed
the
pass-owner-to-all-component-definitions
branch
2 times, most recently
from
bc21723 to
a90521e
Compare
pzuraq
force-pushed
the
pass-owner-to-all-component-definitions
branch
from
a90521e to
434ea5a
Compare
Previously, strict components were not passed an owner when they were defined. This turned out to be incorrect, because even if strict components did not use an owner to resolve components, the components that they used in scope could potentially be non-strict, and resolve components. Those components effectively become different components based on the currently active owner, so we have to pass the owner no matter what type of component we are rendering.
pzuraq
force-pushed
the
pass-owner-to-all-component-definitions
branch
from
434ea5a to
5d1e9c3
Compare
| // TODO: This behavior could be confusing the users, but currently we don't know of a way | ||
| // to ensure we are using the component with the correct owner if it was not curried. | ||
| // We should continue exploring options here. | ||
| @test | ||
| 'owner is preserved in non-curried component definitions that are passed around'(assert: Assert) { | ||
| let owner1 = { name: 'owner1' }; | ||
| let owner2 = { name: 'owner2' }; | ||
|
|
||
| const CheckOwner2 = defineCheckOwnerComponent(owner1, assert); | ||
| const CheckOwner1 = defineCheckOwnerComponent(owner1, assert); | ||
|
|
||
| const Mount2 = defineMountComponent(owner2, { CheckOwner2 }, `<CheckOwner2/><@CheckOwner2/>`); | ||
| const Mount1 = defineMountComponent( | ||
| owner1, | ||
| { CheckOwner1, CheckOwner2, Mount2 }, | ||
| `<CheckOwner1/><Mount2 @CheckOwner2={{CheckOwner2}}/>` | ||
| ); | ||
|
|
||
| this.renderComponent(Mount1); | ||
| } |
There was a problem hiding this comment.
For context, we (@pzuraq + @krisselden + myself) discussed this in detail. The rough conclusion is that we don't really like the thing this test is asserting (it is very strange to end up with an owner from a different invocation than where you were originally associated), but it is quite difficult to ensure that we always have the right owner (it isn't even possible to absorb all variants of things that could be done in JavaScript land).
At the moment, we intend to land this update over in Ember and add a debug only AST transform that wraps any values passed to {{mount 'foo' model= (because as far as we can tell, that is the only way to pass things "across owner / realm") and asserts if you pass something that is a component/helper/modifier that isn't wrapped in (component/(helper/(modifier helpers.
Previously, strict components were not passed an owner when they were
defined. This turned out to be incorrect, because even if strict
components did not use an owner to resolve components, the components
that they used in scope could potentially be non-strict, and resolve
components. Those components effectively become different components
based on the currently active owner, so we have to pass the owner no
matter what type of component we are rendering.