Update main key in package json to reference es2017 bundles #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chiragpat
force-pushed
the
fix-main-path
branch
from
91e7d73 to
dc8b432
Compare
chiragpat
force-pushed
the
fix-main-path
branch
from
dc8b432 to
29126fb
Compare
|
@rwjblue I think this is going to be fine because Ember is going to rollup and transpile anyways but want to confirm before merging. Should we rev the minor in the release? |
|
Yep, seems good to me but labeling as "breaking". |
|
Published as v0.51.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Currently when we try to use glimmer-vm in a node env it pulls in the es5 bundles instead of the es2017 bundle. node > 10 has 100% support for es2017 so we should be able to just pull that in and don't have to run any of the polyfilled features which could have runtime overahead.
How