Add .npmignore files to each public package with a test folder
#1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This teaches the `node/no-unpublished-import` ESLint rule that files within the `test` folder are not published and that it is okay to import dev dependencies from within those files.
rwjblue
approved these changes
Feb 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This teaches the
node/no-unpublished-importESLint rule that files within thetestfolder are not published and that it is okay to import dev dependencies from within those files.I initially tried to use a wildcard in the main
.npmignorefile, but that didn't work properly, so unfortunately I had to use a dedicated.npmignorefile per package.