Merge pull request #1704 from glimmerjs/fix-types-rollup

Fix types rollup
glimmerjs · Feb 10, 2025 · ad7f15f · ad7f15f
2 parents cb9c617 + bc31a41
commit ad7f15f
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 22 deletions.
diff --git a/.github/workflows/plan-release.yml b/.github/workflows/plan-release.yml
@@ -60,10 +60,6 @@ jobs:
       - name: "Generate Explanation and Prep Changelogs"
         id: explanation
         run: |
-          # Don't forget to-re-add these when we update release-plan
-          pnpm repo:update:conventions
-          pnpm repo:update:metadata
-
           # Original Content Here
           set +e
           pnpm release-plan prepare 2> >(tee -a release-plan-stderr.txt >&2)
@@ -79,6 +75,9 @@ jobs:
             rm release-plan-stderr.txt
           fi
 
+          # Don't forget to-re-add these when we update release-plan
+          pnpm repo:update:conventions
+          pnpm repo:update:metadata
 
         env:
           GITHUB_AUTH: ${{ secrets.GITHUB_TOKEN }}

diff --git a/packages/@glimmer-workspace/build/lib/config.js b/packages/@glimmer-workspace/build/lib/config.js
@@ -410,6 +410,7 @@ export class Package {
               output: {
                 dir: `dist/${env}`,
               },
+              external: this.#external,
               plugins: [
                 dts({
                   respectExternal: true,

diff --git a/packages/@glimmer/interfaces/README.md b/packages/@glimmer/interfaces/README.md
@@ -1,6 +1,5 @@
 # @glimmer/interfaces
 
-
-Common interfaces shared among all @glimmer/* projects
+Common interfaces shared among all @glimmer/\* projects
 
 (solving the diamond dependency problem)
diff --git a/repo-metadata/metadata.json b/repo-metadata/metadata.json
@@ -167,7 +167,7 @@
     {
       "root": "packages/@glimmer/compiler",
       "name": "@glimmer/compiler",
-      "version": "0.94.4",
+      "version": "0.94.5",
       "type": "module",
       "private": false,
       "repo-meta": {
@@ -275,7 +275,7 @@
     {
       "root": "packages/@glimmer/destroyable",
       "name": "@glimmer/destroyable",
-      "version": "0.94.3",
+      "version": "0.94.4",
       "type": "module",
       "private": false,
       "repo-meta": {
@@ -301,7 +301,7 @@
     {
       "root": "packages/@glimmer/encoder",
       "name": "@glimmer/encoder",
-      "version": "0.93.3",
+      "version": "0.93.4",
       "type": "module",
       "private": false,
       "repo-meta": {
@@ -327,7 +327,7 @@
     {
       "root": "packages/@glimmer/interfaces",
       "name": "@glimmer/interfaces",
-      "version": "0.94.2",
+      "version": "0.94.3",
       "type": "module",
       "private": false,
       "repo-meta": {
@@ -367,7 +367,7 @@
     {
       "root": "packages/@glimmer/manager",
       "name": "@glimmer/manager",
-      "version": "0.94.3",
+      "version": "0.94.4",
       "type": "module",
       "private": false,
       "repo-meta": {
@@ -394,7 +394,7 @@
     {
       "root": "packages/@glimmer/node",
       "name": "@glimmer/node",
-      "version": "0.94.3",
+      "version": "0.94.4",
       "type": "module",
       "private": false,
       "repo-meta": {
@@ -407,7 +407,7 @@
     {
       "root": "packages/@glimmer/opcode-compiler",
       "name": "@glimmer/opcode-compiler",
-      "version": "0.94.3",
+      "version": "0.94.4",
       "type": "module",
       "private": false,
       "repo-meta": {
@@ -446,7 +446,7 @@
     {
       "root": "packages/@glimmer/program",
       "name": "@glimmer/program",
-      "version": "0.94.3",
+      "version": "0.94.4",
       "type": "module",
       "private": false,
       "repo-meta": {
@@ -472,7 +472,7 @@
     {
       "root": "packages/@glimmer/reference",
       "name": "@glimmer/reference",
-      "version": "0.94.3",
+      "version": "0.94.4",
       "type": "module",
       "private": false,
       "repo-meta": {
@@ -498,7 +498,7 @@
     {
       "root": "packages/@glimmer/runtime",
       "name": "@glimmer/runtime",
-      "version": "0.94.3",
+      "version": "0.94.4",
       "type": "module",
       "private": false,
       "repo-meta": {
@@ -511,7 +511,7 @@
     {
       "root": "packages/@glimmer/syntax",
       "name": "@glimmer/syntax",
-      "version": "0.94.3",
+      "version": "0.94.4",
       "type": "module",
       "private": false,
       "repo-meta": {
@@ -537,7 +537,7 @@
     {
       "root": "packages/@glimmer/util",
       "name": "@glimmer/util",
-      "version": "0.94.3",
+      "version": "0.94.4",
       "type": "module",
       "private": false,
       "repo-meta": {
@@ -563,7 +563,7 @@
     {
       "root": "packages/@glimmer/validator",
       "name": "@glimmer/validator",
-      "version": "0.94.3",
+      "version": "0.94.4",
       "type": "module",
       "private": false,
       "repo-meta": {
@@ -590,7 +590,7 @@
     {
       "root": "packages/@glimmer/vm",
       "name": "@glimmer/vm",
-      "version": "0.94.3",
+      "version": "0.94.4",
       "type": "module",
       "private": false,
       "repo-meta": {
@@ -603,7 +603,7 @@
     {
       "root": "packages/@glimmer/vm-babel-plugins",
       "name": "@glimmer/vm-babel-plugins",
-      "version": "0.93.2",
+      "version": "0.93.3",
       "type": "module",
       "private": false,
       "repo-meta": {
@@ -616,7 +616,7 @@
     {
       "root": "packages/@glimmer/wire-format",
       "name": "@glimmer/wire-format",
-      "version": "0.94.3",
+      "version": "0.94.4",
       "type": "module",
       "private": false,
       "repo-meta": {