Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wa Polls: Added character limit #3223

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Wa Polls: Added character limit #3223

merged 1 commit into from
Feb 17, 2025

Conversation

akanshaaa19
Copy link
Member

target issue is #3222

@akanshaaa19 akanshaaa19 changed the base branch from master to feat/wa_polls February 17, 2025 07:52
Copy link

@github-actions github-actions bot temporarily deployed to pull request February 17, 2025 07:54 Inactive
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.67%. Comparing base (5687a6c) to head (95b4a87).
Report is 2 commits behind head on feat/wa_polls.

Additional details and impacted files
@@                Coverage Diff                @@
##           feat/wa_polls    #3223      +/-   ##
=================================================
+ Coverage          80.65%   80.67%   +0.01%     
=================================================
  Files                327      327              
  Lines              10575    10575              
  Branches            2191     2191              
=================================================
+ Hits                8529     8531       +2     
+ Misses              1430     1429       -1     
+ Partials             616      615       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akanshaaa19 akanshaaa19 requested a review from kurund February 17, 2025 07:59
Copy link

cypress bot commented Feb 17, 2025

Glific    Run #5570

Run Properties:  status check passed Passed #5570  •  git commit 1c832f15d6 ℹ️: Merge 95b4a8748f074c814adf500de2c384ed7bd339db into 207fe06b65190b331e151603f726...
Project Glific
Branch Review wa_polls/char-limit
Run status status check passed Passed #5570
Run duration 26m 02s
Commit git commit 1c832f15d6 ℹ️: Merge 95b4a8748f074c814adf500de2c384ed7bd339db into 207fe06b65190b331e151603f726...
Committer Akansha Sakhre
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 172
View all changes introduced in this branch ↗︎

Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@kurund kurund merged commit 99b0b59 into feat/wa_polls Feb 17, 2025
13 checks passed
@kurund kurund deleted the wa_polls/char-limit branch February 17, 2025 23:29
@akanshaaa19 akanshaaa19 linked an issue Feb 24, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WA Groups: Add length limit in Poll fields
2 participants