Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add raise to gupshup option #2702

Merged
merged 11 commits into from
Jan 31, 2024
Merged

Add raise to gupshup option #2702

merged 11 commits into from
Jan 31, 2024

Conversation

akanshaaa19
Copy link
Member

@akanshaaa19 akanshaaa19 commented Jan 17, 2024

Summary

#2512

Test Plan

@akanshaaa19 akanshaaa19 changed the base branch from master to next January 17, 2024 04:13
@akanshaaa19 akanshaaa19 marked this pull request as ready for review January 17, 2024 11:15
Copy link

github-actions bot commented Jan 17, 2024

@github-actions github-actions bot temporarily deployed to pull request January 17, 2024 11:21 Inactive
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (4ceb5b5) 72.28% compared to head (5ea8b17) 72.26%.

Files Patch % Lines
src/containers/Template/List/RaiseToGupShup.tsx 78.26% 5 Missing ⚠️
src/containers/Template/List/Template.tsx 60.00% 3 Missing and 1 partial ⚠️
src/containers/List/List.tsx 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2702      +/-   ##
==========================================
- Coverage   72.28%   72.26%   -0.02%     
==========================================
  Files         281      283       +2     
  Lines        8782     8817      +35     
  Branches     1851     1853       +2     
==========================================
+ Hits         6348     6372      +24     
- Misses       1806     1815       +9     
- Partials      628      630       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to pull request January 18, 2024 03:52 Inactive
@akanshaaa19 akanshaaa19 requested a review from mdshamoon January 18, 2024 03:55
@github-actions github-actions bot temporarily deployed to pull request January 29, 2024 09:24 Inactive
@akanshaaa19 akanshaaa19 requested a review from kurund January 29, 2024 09:25
Copy link
Member

@mdshamoon mdshamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Title and cross icon are overlapping. Please add some margin.

@github-actions github-actions bot temporarily deployed to pull request January 30, 2024 10:57 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 30, 2024 11:09 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 30, 2024 15:37 Inactive
@akanshaaa19 akanshaaa19 requested a review from mdshamoon January 30, 2024 15:55
@github-actions github-actions bot temporarily deployed to pull request January 30, 2024 17:40 Inactive
@mdshamoon mdshamoon linked an issue Jan 31, 2024 that may be closed by this pull request
@mdshamoon mdshamoon merged commit 1986e5e into next Jan 31, 2024
7 of 9 checks passed
@mdshamoon mdshamoon deleted the add-raise-to-gupshup-option branch January 31, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Released on production
Development

Successfully merging this pull request may close these issues.

Add raise to gupshup option in the templates section
2 participants