Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete existing memo files by default? #136

Closed
Tracked by #140
melissalinkert opened this issue Mar 2, 2022 · 2 comments · Fixed by #145
Closed
Tracked by #140

Delete existing memo files by default? #136

melissalinkert opened this issue Mar 2, 2022 · 2 comments · Fixed by #145

Comments

@melissalinkert
Copy link
Member

If a memo file already exists before the conversion is started, it will be used if it is compatible with the current Bio-Formats version. This can lead to confusion if conversion is being tested with different reader options, since the memo file effectively overrides any options changes.

It might be better to default to deleting the memo file (if it exists) before the first setId call, and add an option to keep the memo file for the rare cases when that is necessary. Memoizer.getMemoFile(String) should make that easy.

@sbesson
Copy link
Member

sbesson commented Mar 3, 2022

Another (complementary?) approach would be to delete the memo file at the end of the process.

Since the primary scope of this utility is to perform a one-off conversion and this file is primarily generated for performance, at least from my side, there is no persistence expectation and it would be completely acceptable to remove it once the computation is complete.

@joshmoore
Copy link
Contributor

With the caveat that if it exists beforehand, it likely shouldn't be deleted by default afterwards (e.g. in the IDR case)

@melissalinkert melissalinkert mentioned this issue Mar 15, 2022
8 tasks
@melissalinkert melissalinkert moved this to 0.5.0 in Converters Mar 17, 2022
melissalinkert added a commit to melissalinkert/bioformats2raw that referenced this issue Mar 31, 2022
--keep-memo-files disables memo file deletion. If the memo file existed
before conversion started, it shouldn't be deleted either way.

Fixes glencoesoftware#136
Repository owner moved this from 0.5.0 to Done in Converters May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants