-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete existing memo files by default? #136
Comments
Another (complementary?) approach would be to delete the memo file at the end of the process. Since the primary scope of this utility is to perform a one-off conversion and this file is primarily generated for performance, at least from my side, there is no persistence expectation and it would be completely acceptable to remove it once the computation is complete. |
With the caveat that if it exists beforehand, it likely shouldn't be deleted by default afterwards (e.g. in the IDR case) |
--keep-memo-files disables memo file deletion. If the memo file existed before conversion started, it shouldn't be deleted either way. Fixes glencoesoftware#136
If a memo file already exists before the conversion is started, it will be used if it is compatible with the current Bio-Formats version. This can lead to confusion if conversion is being tested with different reader options, since the memo file effectively overrides any options changes.
It might be better to default to deleting the memo file (if it exists) before the first
setId
call, and add an option to keep the memo file for the rare cases when that is necessary.Memoizer.getMemoFile(String)
should make that easy.The text was updated successfully, but these errors were encountered: