Ignore key if scope cannot be evaluated

- Fixes #441
glebm · Apr 5, 2022 · 9d2c825 · 9d2c825
1 parent fed0923
commit 9d2c825
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/i18n/tasks/scanners/ast_matchers/message_receivers_matcher.rb b/lib/i18n/tasks/scanners/ast_matchers/message_receivers_matcher.rb
@@ -27,6 +27,8 @@ def convert_to_key_occurrences(send_node, method_name, location: send_node.loc)
 
       key, default_arg = process_options(node: second_arg_node, key: key)
 
+      return if key.nil?
+
       [
         full_key(receiver: receiver, key: key, location: location, calling_method: method_name),
         I18n::Tasks::Scanners::Results::Occurrence.from_range(
@@ -71,7 +73,7 @@ def process_options(node:, key:)
           array_flatten: true,
           array_reject_blank: true
         )
-        return [key, nil] if scope.nil? && scope_node.type != :nil
+        return nil if scope.nil? && scope_node.type != :nil
 
         key = [scope, key].join('.') unless scope == ''
       end

diff --git a/spec/fixtures/used_keys/a.rb b/spec/fixtures/used_keys/a.rb
@@ -13,4 +13,10 @@ def self.whot
     I18n.t('activerecord.attributes.absolute.attribute')
     translate('activerecord.attributes.absolute.attribute')
   end
+
+  SCOPE_CONSTANT = 'path.in.translation.file'.freeze
+  def issue441
+    t('ignore_a', scope: SCOPE_CONSTANT)
+    t('ignore_b', scope: SCOPE_CONSTANT)
+  end
 end