Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump glslify, fix deps #2

Merged
merged 1 commit into from
Feb 2, 2018
Merged

Bump glslify, fix deps #2

merged 1 commit into from
Feb 2, 2018

Conversation

dy
Copy link
Member

@dy dy commented Feb 2, 2018

plotly/plotly.js#2321 + makes sure example is runnable

@etpinard
Copy link
Member

etpinard commented Feb 2, 2018

💃

@dy dy merged commit 66be69b into master Feb 2, 2018
@dy dy deleted the glslify branch February 2, 2018 20:58
@dy
Copy link
Member Author

dy commented Feb 2, 2018

@etpinard @monfera can you please do npm publish here or grant me permission npm owner add dfcreative gl-pointcloud2d

@etpinard
Copy link
Member

etpinard commented Feb 2, 2018

I don't have publish rights for gl-pointcloud2d unfortunately. So it's up to @monfera (no rush though 😄 )

@etpinard etpinard mentioned this pull request Feb 2, 2018
@monfera
Copy link
Member

monfera commented Feb 4, 2018

@dfcreative @etpinard thanks for the note, I just added both of you, tell me if it doesn't work out.
image

Have we a codepen similar to this that shows the (by client requirement, low) initialization and update latency? I just re-checked it, it used to be 25-30FPS but now only around half of that, not sure if it's due to possibly slower browser / OS versions. We must be able to do a redraw cycle in <100ms so we're still good; I'm sure the new thing is as good or is an improvement.

@etpinard
Copy link
Member

etpinard commented Feb 5, 2018

@monfera are you suggesting that bumping the glslify version slowed down pointcloud?

@monfera
Copy link
Member

monfera commented Feb 5, 2018

@etpinard no, because that wouldn't have changed the shader code; there might have been some general or WebGL specific slowdown in browsers. Fixes for things like Meltdown, Spectre or bugs may influence performance.

@etpinard
Copy link
Member

etpinard commented Feb 5, 2018

Ah nice. Good to know. Thanks for pointing this out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants