Fix various potential memory misuses #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
root-hardenedvault
force-pushed
the
fix-f_misuse
branch
from
497176a to
7f44ed1
Compare
|
hi @root-hardenedvault, thanks once again for your contribution 🙂 i still remember trying to find out whether good thing you caught both of these things. could you fix the missing semicolon at the end of line 502 (as the CI pointed out) so i can merge? |
* g_free() of libglib is not interchangeable with free() of libc, if glib is built with ENABLE_MEM_PROFILE or ENABLE_MEM_CHECK defined, so memory allocated with g_malloc() family should be released with g_free() rather than free(), as https://mail.gnome.org/archives/gtk-list/2000-July/msg00002.html pointed out. * the return value of xmlnode_to_str() should be released with g_free(), otherwise it is leaked. Signed-off-by: HardenedVault <[email protected]>
root-hardenedvault
force-pushed
the
fix-f_misuse
branch
from
7f44ed1 to
24555c2
Compare
|
Fixed. The codecov report shouldn't bothers? |
|
thanks! yeah, just ignore the codecov stuff. i need to configure it better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
g_free() of libglib is not interchangeable with free() of libc, if
glib is built with ENABLE_MEM_PROFILE or ENABLE_MEM_CHECK defined,
so memory allocated with g_malloc() family should be released with
g_free() rather than free(), as
https://mail.gnome.org/archives/gtk-list/2000-July/msg00002.html
pointed out.
the return value of xmlnode_to_str() should be released with
g_free(), otherwise it is leaked.
Signed-off-by: HardenedVault [email protected]