Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing symlinks libomemo.so.$(VER_MAJ) and libomemo.so #34

Merged
merged 1 commit into from
Mar 3, 2021

Conversation

hartwork
Copy link
Contributor

@hartwork hartwork commented Feb 21, 2021

Hi!

I use this patch in Gentoo packaging of libomemo. My interest is to get this patch (or some form of this patch) applied upstream so that (1) others can get the patch out of the box and (2) my own patch count downstream in Gentoo goes back to zero, e.g. to reduce the risk of merge conflicts with the next upstream release…

What do you think about the patch?

Best

Sebastian

PS: This pull request has a sibling at gkdr/axc#24

@hartwork
Copy link
Contributor Author

hartwork commented Mar 2, 2021

@gkdr any thoughts?

@gkdr
Copy link
Owner

gkdr commented Mar 3, 2021

hi @hartwork,
thanks for the patch. my thoughts are that i'm sorry that i didn't have time to look at this yet 😬 your contribution does sound useful, the only issue is on my side: i don't know how to check whether it works as intended so i'd have to search the internet for a bit.

@fortysixandtwo, you originally contributed the feature. could you maybe help me speed this up with your expert knowledge? 🙂

@fortysixandtwo
Copy link
Contributor

Looks good and let's us get rid of explicitly doing the symlinks in Debian too:
https://salsa.debian.org/DebianOnMobile-team/libomemo/-/blob/debian/master/debian/rules#L26

@hartwork
Copy link
Contributor Author

hartwork commented Mar 3, 2021

Cool!

@gkdr
Copy link
Owner

gkdr commented Mar 3, 2021

thanks a lot, both of you!

@gkdr gkdr changed the base branch from master to dev March 3, 2021 21:51
@gkdr gkdr merged commit 5591d9b into gkdr:dev Mar 3, 2021
@hartwork hartwork deleted the makefile-create-shared-library-symlinks branch January 20, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants