prekey attribute not added when sending a PreKeySignalMessage

[mar-v-in]

According to XEP-0384 (version 0.3.0) §4.5:

The key element MUST be tagged with a prekey attribute set to true if a PreKeySignalMessage is being used.

This behavior is not implemented in libomemo.

[gkdr]

hi, and thanks for the report. i slightly remember that it was not required when i first implemented it, i'll check out what needs to be done.

[gkdr]

it should not be hard, i just need an additional function that does the same but adds the attribute. does anything break already without this?

[mar-v-in]

Dino does check if the prekey attribute is present, which means that libomemo can't open sessions with Dino. But sessions can be created the other way round, so users natural response "something didn't work" already fixes it, making it a bad UX, but nothing critical.

[gkdr]

this issue was not automatically closed, presumably because i changed the default branch before the commit referencing this issue was merged from the then-not-default branch to the then-default branch. so i'm closing it manually now 🙂