Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix test compile warnings #33

Merged
merged 3 commits into from
Jan 28, 2022
Merged

fix test compile warnings #33

merged 3 commits into from
Jan 28, 2022

Conversation

gkdr
Copy link
Owner

@gkdr gkdr commented Jan 27, 2022 •
edited
Loading

edit: autogenerated pr body was for merge against master, which included changes from dev. just confusing so i deleted it.

@gkdr gkdr changed the base branch from master to dev January 27, 2022 20:29
@gkdr
Copy link
Owner Author

gkdr commented Jan 27, 2022

guess github actions does its thing on prs too @hartwork 🙂

hartwork
hartwork approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@hartwork hartwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gkdr so the code is warning free now? Nice! I hope it's okay that I haven't checked how you fixed the warnings in detail. Anything left to do before a merge? I'll rebase my cmake branch on top of the new dev right after.

@gkdr
Copy link
Owner Author

gkdr commented Jan 28, 2022

Anything left to do before a merge?

don't think so :D

@gkdr gkdr merged commit b32dc8d into dev Jan 28, 2022
@gkdr gkdr deleted the fix-test-compile-warnings branch January 28, 2022 06:56
@hartwork
Copy link
Contributor

Anything left to do before a merge?

don't think so :D

@gkpr excellent, I have rebased PR #32 onto latest dev now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hartwork hartwork hartwork approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gkdr @hartwork