-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build all types without errors + migrate to ESM + type definition improvements #44
Conversation
… to check new generation features)
Great work @JumpLink . I've started reading through it, but there is quite a lot here! Will look to get it merged by the weekend |
@sammydre Yes I should get out of the habit of these big PR's. Sorry that happened to me again. I think it makes the most sense if you just look at the The change from
And the new types are those that start with In the ava tests, I had to add lines like these: mod.symTable.set(mod.dependencies, 'Test.MyType', emptyConstruct) Since the I had to touch almost all other files, because I had to adjust the imports to make them work with ESM. |
npm run test:girs:all
, this test is now also executed with github actionsoclif
withyargs
for CLI parsing (yargs
has ESM Support,oclif
not)examples/Gjs/builder
example to use the Gjs ESM feature usinggi://
importsMost of my changes were some time ago, so I had to fix some merge conflicts, I hope I didn't break any of @realh's changes. But the ESM feature works as you can see in the examples/Gjs/browser example.
Breaking Changes
Before:
After:
@realh can you test my changes to make sure nothing of your improvements are broken?