feat(multiselect): set some elements as slot to promote customization #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ser customization docs(multiselect): add new story for new selection and max selection in storybook docs(multiselect): add new slots in vuepress docs
gretchelin
force-pushed
the
feat/multiselect-slots
branch
from
7ebc761 to
6434a28
Compare
docs(multiselect): add new story for select all slot docs(multiselect): add select all slot to vuepress docs entry
gretchelin
force-pushed
the
feat/multiselect-slots
branch
from
2fd336f to
b3028d2
Compare
docs(multiselect): add story for append.item and prepend.item slot docs(multiselect): add append.tem and prepend.item slot to vuepress entry
…omization docs(multiselect): add new story for option label slot docs(multiselect): add option label slot in vuepress doc entry
gretchelin
changed the title
|
@gravitano might want to check into slot naming. I didn't see any rule about slot naming for this project, so idk if the slot names I set up in this PR are okay or should be changed to a specific pattern. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes
selection,max-selection,select-allandoption item labelcontent as slot to accommodate custom rendering needs. Also created two slot position in option to enable prepend and appending custom to item list.Storybook story and vuepress docs for this component has been updated to reflect these changes.