Fix crash in auto hide tab #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Crash is caused by dragging an autohide tab out when it is an icon only. - The crash can actually happen with non icon only tabs, but is masked by the orientation check. - Soln: Check if auto hide container exists first on mouse finish dragging event.
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @githubuser0xFFFF, hope you are doing well 😄
Here's a bug fix for a small crash that I found.
How to reproduce:
AdvancedDockingSystem::MainWindow, addCDockManager::setAutoHideConfigFlag(CDockManager::AutoHideSideBarsIconOnly);CAutoHideTab::mouseReleaseEvent->d->DockWidget->autoHideDockContainer()->resetToInitialDockWidgetSize();because autoHideDockContainer is nullptrFix
The crash can actually happen with non icon only tabs, but is masked by the orientation check, this is why it doesn't happen normally.
Fix: Check if auto hide container exists first on mouse finish dragging event.