-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade PyQt build #404
upgrade PyQt build #404
Conversation
Thank you for your contribution. I cannot help you much, because I have not experience yet with PyQt. Just tell me when you think the pull request is ready and I will merge it. |
f953c0d
to
0cb13e3
Compare
I fixed the build problem, no hardcoded path any more :) I'm going to test this on some more platforms, and tell you once it's ready. |
43c5aa0
to
184e111
Compare
184e111
to
a688585
Compare
This sounds great. Thank you very much for your help. |
20fa3a1
to
a173fc9
Compare
@luelista Do I understand correctly that when you're done - there will be a PyPi package that can be installed with modern versions of pyqt-sip and pyqt ? |
@Zholtikov it is already possible to install, I put up a WIP version on PyPI: https://pypi.org/project/PyQtAds/ @githubuser0xFFFF |
Thank you very much for this great contribution, |
Hi,
I'm working on upgrading the build process of the PyQt bindings to the current recommendations of the PyQt-builder / sip authors, so that it works with the current version of sip and pip.
It's currently WIP because I can't build the resources file (ads.qrc) reliably yet. It only works if the build directory is in a subfolder of the main repo, because I had to hardcode the path in the config file (
qmake-settings = ["RESOURCES += ../../src/ads.qrc"]
.Once I found out the right way to solve this I'll update this PR. I thought I'd still open this already, if you have any feedback regarding this update.