Follow redirects in GitHubPages::HealthCheck#served_by_pages?

[jdennes]

Many apex domains like http://getbootstrap.com/ use A records (rather than ALIAS/ANAME records):

› dig getbootstrap.com
;getbootstrap.com.      IN  A
getbootstrap.com.   9072    IN  A   192.30.252.154
getbootstrap.com.   9072    IN  A   192.30.252.153

GitHub Pages will sometimes respond with a 302 Found for these domains:

› curl -I http://getbootstrap.com/
HTTP/1.1 302 Found
Location: /

Previously the GitHubPages::HealthCheck#served_by_pages? check could fail because it would make a request which would respond with a 302 Found and the Server: github.com header wouldn't be included in the response.

This fixes the issue by retrying the request, which should then result in a 200 OK response which includes the Server: github.com header.

/cc @benbalter

[spraints]

It looks like it doesn't actually follow the redirect, but instead requests the same URL again. That should be OK in this case, since it ends up making the same request.

👍

[jdennes]

@spraints Yes, correct. I have run script/cibuild quite a few times to test this out and it was still occasionally failing with the single retry. I've just made a slight change to retry a maximum of three times. What do you think? Doesn't look like CI is set up correctly for this repository currently...

[benbalter]

Nice catch. 👍

[spraints]

Doesn't look like CI is set up correctly for this repository currently...

This repository is public. IIRC our CI will not run for public repositories. Maybe we should set up a travis CI build for this?

[jdennes]

Maybe we should set up a travis CI build for this?

I think it was intended for script/cibuild to be run on Travis CI. Not sure why it's not currently.

[benbalter]

I think it was intended for script/cibuild to be run on Travis CI. Not sure why it's not currently.

When the Gem was released it was when we were testing some of the new Org Oauth Whitelisting which is now public. There was a hiccup with Travis's ability to properly setup the webhook. Looks like it's live now. Thanks @jdennes!