Update adding-a-new-ssh-key-to-your-github-account.md #1683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifying that the SSH key to copy is the public one.
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
|
@ealmonte32 Thanks so much for opening a PR! I'll get this triaged for review ⚡ |
janiceilene
added
content
hubwriter
approved these changes
Dec 2, 2020
There was a problem hiding this comment.
@ealmonte32 - Many thanks for this contribution to the docs.
Thanks also for the rationale for the change - it's an important point, I agree.
We really appreciate you taking the time to help improve GitHub documentation. Thanks again! 👏
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
This was referenced Oct 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifying that the SSH key to copy is the public one.
Why:
Because when giving instructions about something that deals with cybersecurity and as important as SSH keys, we must not forget that being very detailed and specific goes a long way to prevent issues.
I believe when you are telling someone to copy their SSH key, you need to be very specific and mention "public" in that instruction, even if its obvious.
What's being changed:
Just adding the word
publicto the SSH and CPG keys instruction page.Check off the following: