Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Add failing ESSA use-use test #10998

Merged
merged 2 commits into from
Oct 31, 2022
Merged

Conversation

RasmusWL
Copy link
Member

I initially created this as a dataflow test, but then realized it could just be an ESSA test. I couldn't find any existing ESSA tests though :| so created a new dir for it.

@yoff let me know if you think this should actually be under our dataflow tests, since the adjacent use-use was only added to serve the new dataflow lib.

I initially created this as a dataflow test, but then realized it could
just be an ESSA test. I cound't find any existing ESSA tests though :|
so created a new dir for it.
@RasmusWL RasmusWL requested a review from a team as a code owner October 26, 2022 15:51
tausbn
tausbn previously approved these changes Oct 26, 2022
Copy link
Contributor

@tausbn tausbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks reasonable (but I'll hold off on merging so yoff can have a gander). 👍

Copy link
Contributor

@yoff yoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice to have this test! 👍
Only reason I mention changes is that it looks different from the code in data flow and I had to remind myself that it does the same thing.

I think it is fine to keep the test here by the predicates they test.

python/ql/test/library-tests/essa/ssa-compute/UseUse.ql Outdated Show resolved Hide resolved
python/ql/test/library-tests/essa/ssa-compute/UseUse.ql Outdated Show resolved Hide resolved
@RasmusWL RasmusWL requested a review from yoff October 28, 2022 13:31
Copy link
Contributor

@yoff yoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RasmusWL RasmusWL merged commit ead0844 into github:main Oct 31, 2022
@RasmusWL RasmusWL deleted the essa-use-use-test branch October 31, 2022 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants