Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix full reference link example #157

Closed
wants to merge 1 commit into from
Closed

Fix full reference link example #157

wants to merge 1 commit into from

Conversation

JohelEGP
Copy link

According to the introducing text, this example "illustrate[s] the precedence of link text grouping over emphasis grouping." The added * makes it look like an emphasis.

@kivikakk
Copy link

I'll open this upstream, as it comes from the base CommonMark spec.

@JohelEGP
Copy link
Author

Shall I do that in the future?

@kivikakk
Copy link

Here it is: commonmark/commonmark-spec#584.

Shall I do that in the future?

If it's part of the base spec, yes please! If it relates to a GFM extension, then here is the correct place 👍

jgm pushed a commit to commonmark/commonmark-spec that referenced this pull request May 15, 2019
@kivikakk
Copy link

Upstream has committed your change! Spec changes have been merged in 4b6ceb6. Thank you!

@kivikakk kivikakk closed this May 15, 2019
@JohelEGP JohelEGP deleted the full_reference_link branch May 15, 2019 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants