Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error handling ergonomics #3898

Merged
merged 14 commits into from
Jun 1, 2024
Merged

error handling ergonomics #3898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
d689f36
various refactors
Byron May 30, 2024
20d8424
Prune `Code` to only what's used by the UI
Byron May 30, 2024
1dc52a4
restore detection of project conflicts
Byron May 30, 2024
61a53c6
Another pass at removing `ProjectConflict`
Byron May 30, 2024
a95c48a
remove DefaultTargetNotSet in favor of a utility function
Byron May 31, 2024
c0fc0cf
Remove `BranchNotFound` struct
Byron May 31, 2024
e7c1d60
Remove all errors that don't trigger a custom code or context
Byron May 31, 2024
f82d257
use `Marker` in place of `Code::ProjectInvalid`
Byron May 31, 2024
939624f
Remove all custom errors from virtual branches module.
Byron May 31, 2024
a10b19e
reomve all `thiserror` based errors from controllers
Byron May 31, 2024
0ef944e
Switch `thiserror` with `anyhow` based errors in application code
Byron May 31, 2024
567a077
simplify core::errors and remove all the cruft
Byron May 31, 2024
83893a9
review error docs to fit the latest changes
Byron Jun 1, 2024
dedd721
capitalize error message
Byron Jun 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions app/src/lib/backend/ipc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,7 @@ import type { EventCallback, EventName } from '@tauri-apps/api/event';
export enum Code {
Unknown = 'errors.unknown',
Validation = 'errors.validation',
Projects = 'errors.projects',
ProjectsGitAuth = 'errors.projects.git.auth',
ProjectsGitRemote = 'errors.projects.git.remote',
ProjectHead = 'errors.projects.head',
ProjectConflict = 'errors.projects.conflict'
ProjectsGitAuth = 'errors.projects.git.auth'
}

export class UserError extends Error {
Expand All @@ -26,10 +22,17 @@ export class UserError extends Error {
const cause = error instanceof Error ? error : undefined;
const code = error.code ?? Code.Unknown;
const message = error.message ?? error;
return new UserError(message, code, cause);
return new UserError(capitalize(message), code, cause);
}
}

function capitalize(str: string): string {
if (str.length === 0) {
return str;
}
return str.charAt(0).toUpperCase() + str.slice(1);
}

export async function invoke<T>(command: string, params: Record<string, unknown> = {}): Promise<T> {
// This commented out code can be used to delay/reject an api call
// return new Promise<T>((resolve, reject) => {
Expand Down
Loading
Loading