sync-all on Windows #3619
Merged
sync-all on Windows #3619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Byron
force-pushed
the
no-tempfiles-on-windows
branch
3 times, most recently
from
a9adb92 to
ce724df
Compare
GB writes files atomically and in the end it boils down to allocating bytes and writing them all at once. Now this capability lives in the `fs` module.
…rapp#3601) Until `perist()` is truly atomic also on Windows, and modelled [after Git](https://github.com/git/git/blob/master/compat/mingw.c#L2159-L2209), sans the retries, it seems to work to just perform ordinary writes. Before going there though, we try to call `sync_all()` on Windows to truly finish the operation. On Unix, a rename is already supposed to be atomic.
Byron
force-pushed
the
no-tempfiles-on-windows
branch
from
ce724df to
4f58883
Compare
krlvi
approved these changes
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a file was moved into place on Windows, it's possible to call
sync_allon Windows to force it to arrive for good,at least so we hope.
If it works, the access-denied errors should go away (#3601), for now.
Thanks a lot, @daniilS, for suggesting to try this!
If it doesn't turn out to be effective, it appears we can always go back to the previous version of the code until more
flags could be tried, and possible submit a patch upstream eventually.
But even if it is effective, it introduces an extra syscall on Windows which shouldn't be required,
so ultimately the effectiveness of such an improvement in
tempfilewill have to be verified and then submitted upstream.