-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cred helper improvements #2695
Merged
Merged
Cred helper improvements #2695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here are some sample builds in case anyone wants to try this out: git-lfs-darwin-amd64-2.3.4.tar.gz |
This was referenced Oct 27, 2017
rubyist
approved these changes
Oct 27, 2017
As mentioned in #2634 (comment) I tested the linux build and confirmed they resolve #2695 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for per-url credential helpers (#2686) and fixes performance issues discussed in #2690.
path
to credential helpers ifcredential.useHttpPath
is enabled.credential.<url>.usehttppath
andcredential.<url>.helper
By creating the credential helper per request, any notion of a cache is lost. So, there's still more work to be done in
(*Client) getCredentialHelper
.