mimalloc: allow running in Windows Nano Server containers #4074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `GetNumaProcessorNode()` symbol is not defined in Nano Server's DLLs (because that function is long deprecated). This caused Git no longer to work on Nano Server. Instead of importing it statically, try to import it dynamically, and fall back gracefully if it cannot be loaded. This fixes git-for-windows#4052 Signed-off-by: Johannes Schindelin <[email protected]>
dscho
force-pushed
the
mimalloc-and-nano-server
branch
from
8c2ffc0 to
d32797f
Compare
dscho
added a commit
to dscho/git-sdk-64
that referenced
this pull request
Nov 2, 2022
Signed-off-by: Johannes Schindelin <[email protected]>
dscho
added a commit
to dscho/git-sdk-64
that referenced
this pull request
Nov 2, 2022
Signed-off-by: Johannes Schindelin <[email protected]>
dscho
added a commit
to dscho/git-sdk-64
that referenced
this pull request
Nov 2, 2022
Signed-off-by: Johannes Schindelin <[email protected]>
dscho
added a commit
to dscho/git-sdk-64
that referenced
this pull request
Nov 2, 2022
Signed-off-by: Johannes Schindelin <[email protected]>
dscho
added a commit
to dscho/git-sdk-64
that referenced
this pull request
Nov 2, 2022
Signed-off-by: Johannes Schindelin <[email protected]>
dscho
added a commit
to dscho/git-sdk-64
that referenced
this pull request
Nov 2, 2022
It was reported in git-for-windows/git#4052 that Git for Windows v2.38.0 introduced a regression where `git.exe` could no longer be run in Nano Server containers. The issue was fixed in git-for-windows/git#4074 Let's add a workflow that verifies that Git for Windows does not regress on this in the future. Signed-off-by: Johannes Schindelin <[email protected]>
dscho
added a commit
to dscho/git-sdk-64
that referenced
this pull request
Nov 2, 2022
Signed-off-by: Johannes Schindelin <[email protected]>
dscho
force-pushed
the
mimalloc-and-nano-server
branch
from
d32797f to
4afcf0e
Compare
dscho
added a commit
to dscho/git-sdk-64
that referenced
this pull request
Nov 2, 2022
It was reported in git-for-windows/git#4052 that Git for Windows v2.38.0 introduced a regression where `git.exe` could no longer be run in Nano Server containers. The issue was fixed in git-for-windows/git#4074 Let's add a workflow that verifies that Git for Windows does not regress on this in the future. Signed-off-by: Johannes Schindelin <[email protected]>
This was referenced Nov 2, 2022
Merged
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 3, 2022
The `GetNumaProcessorNode()` symbol is not defined in Nano Server's DLLs (because that function is long deprecated). This caused Git no longer to work on Nano Server. Instead of importing it statically, try to import it dynamically, and fall back gracefully if it cannot be loaded. This fixes #4052
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 3, 2022
The `GetNumaProcessorNode()` symbol is not defined in Nano Server's DLLs (because that function is long deprecated). This caused Git no longer to work on Nano Server. Instead of importing it statically, try to import it dynamically, and fall back gracefully if it cannot be loaded. This fixes #4052
dscho
added a commit
to git-for-windows/build-extra
that referenced
this pull request
Nov 3, 2022
A [regression](git-for-windows/git#4052) introduced in Git for Windows v2.38.0 that prevented `git.exe` from running in Windows Nano Server containers [was fixed](git-for-windows/git#4074). Signed-off-by: Johannes Schindelin <[email protected]>
dscho
added a commit
that referenced
this pull request
Nov 3, 2022
The `GetNumaProcessorNode()` symbol is not defined in Nano Server's DLLs (because that function is long deprecated). This caused Git no longer to work on Nano Server. Instead of importing it statically, try to import it dynamically, and fall back gracefully if it cannot be loaded. This fixes #4052
dscho
added a commit
that referenced
this pull request
Nov 3, 2022
The `GetNumaProcessorNode()` symbol is not defined in Nano Server's DLLs (because that function is long deprecated). This caused Git no longer to work on Nano Server. Instead of importing it statically, try to import it dynamically, and fall back gracefully if it cannot be loaded. This fixes #4052
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 4, 2022
The `GetNumaProcessorNode()` symbol is not defined in Nano Server's DLLs (because that function is long deprecated). This caused Git no longer to work on Nano Server. Instead of importing it statically, try to import it dynamically, and fall back gracefully if it cannot be loaded. This fixes #4052
dscho
added a commit
that referenced
this pull request
Nov 4, 2022
The `GetNumaProcessorNode()` symbol is not defined in Nano Server's DLLs (because that function is long deprecated). This caused Git no longer to work on Nano Server. Instead of importing it statically, try to import it dynamically, and fall back gracefully if it cannot be loaded. This fixes #4052
dscho
added a commit
that referenced
this pull request
Nov 4, 2022
The `GetNumaProcessorNode()` symbol is not defined in Nano Server's DLLs (because that function is long deprecated). This caused Git no longer to work on Nano Server. Instead of importing it statically, try to import it dynamically, and fall back gracefully if it cannot be loaded. This fixes #4052
dscho
added a commit
that referenced
this pull request
Nov 7, 2022
The `GetNumaProcessorNode()` symbol is not defined in Nano Server's DLLs (because that function is long deprecated). This caused Git no longer to work on Nano Server. Instead of importing it statically, try to import it dynamically, and fall back gracefully if it cannot be loaded. This fixes #4052
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 8, 2022
The `GetNumaProcessorNode()` symbol is not defined in Nano Server's DLLs (because that function is long deprecated). This caused Git no longer to work on Nano Server. Instead of importing it statically, try to import it dynamically, and fall back gracefully if it cannot be loaded. This fixes #4052
dscho
added a commit
that referenced
this pull request
Nov 9, 2022
The `GetNumaProcessorNode()` symbol is not defined in Nano Server's DLLs (because that function is long deprecated). This caused Git no longer to work on Nano Server. Instead of importing it statically, try to import it dynamically, and fall back gracefully if it cannot be loaded. This fixes #4052
dscho
added a commit
that referenced
this pull request
Nov 9, 2022
The `GetNumaProcessorNode()` symbol is not defined in Nano Server's DLLs (because that function is long deprecated). This caused Git no longer to work on Nano Server. Instead of importing it statically, try to import it dynamically, and fall back gracefully if it cannot be loaded. This fixes #4052
dscho
added a commit
to dscho/git-sdk-64
that referenced
this pull request
Nov 9, 2022
It was reported in git-for-windows/git#4052 that Git for Windows v2.38.0 introduced a regression where `git.exe` could no longer be run in Nano Server containers. The issue was fixed in git-for-windows/git#4074 Let's add a workflow that verifies that Git for Windows does not regress on this in the future. Signed-off-by: Johannes Schindelin <[email protected]>
dscho
added a commit
that referenced
this pull request
Nov 9, 2022
The `GetNumaProcessorNode()` symbol is not defined in Nano Server's DLLs (because that function is long deprecated). This caused Git no longer to work on Nano Server. Instead of importing it statically, try to import it dynamically, and fall back gracefully if it cannot be loaded. This fixes #4052
dscho
added a commit
that referenced
this pull request
Nov 10, 2022
The `GetNumaProcessorNode()` symbol is not defined in Nano Server's DLLs (because that function is long deprecated). This caused Git no longer to work on Nano Server. Instead of importing it statically, try to import it dynamically, and fall back gracefully if it cannot be loaded. This fixes #4052
dscho
added a commit
that referenced
this pull request
Nov 10, 2022
The `GetNumaProcessorNode()` symbol is not defined in Nano Server's DLLs (because that function is long deprecated). This caused Git no longer to work on Nano Server. Instead of importing it statically, try to import it dynamically, and fall back gracefully if it cannot be loaded. This fixes #4052
dscho
added a commit
that referenced
this pull request
Nov 12, 2022
The `GetNumaProcessorNode()` symbol is not defined in Nano Server's DLLs (because that function is long deprecated). This caused Git no longer to work on Nano Server. Instead of importing it statically, try to import it dynamically, and fall back gracefully if it cannot be loaded. This fixes #4052
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 15, 2022
The `GetNumaProcessorNode()` symbol is not defined in Nano Server's DLLs (because that function is long deprecated). This caused Git no longer to work on Nano Server. Instead of importing it statically, try to import it dynamically, and fall back gracefully if it cannot be loaded. This fixes #4052
dscho
added a commit
that referenced
this pull request
Nov 15, 2022
The `GetNumaProcessorNode()` symbol is not defined in Nano Server's DLLs (because that function is long deprecated). This caused Git no longer to work on Nano Server. Instead of importing it statically, try to import it dynamically, and fall back gracefully if it cannot be loaded. This fixes #4052
dscho
added a commit
that referenced
this pull request
Nov 15, 2022
The `GetNumaProcessorNode()` symbol is not defined in Nano Server's DLLs (because that function is long deprecated). This caused Git no longer to work on Nano Server. Instead of importing it statically, try to import it dynamically, and fall back gracefully if it cannot be loaded. This fixes #4052
dscho
added a commit
that referenced
this pull request
Nov 16, 2022
The `GetNumaProcessorNode()` symbol is not defined in Nano Server's DLLs (because that function is long deprecated). This caused Git no longer to work on Nano Server. Instead of importing it statically, try to import it dynamically, and fall back gracefully if it cannot be loaded. This fixes #4052
dscho
added a commit
that referenced
this pull request
Nov 16, 2022
The `GetNumaProcessorNode()` symbol is not defined in Nano Server's DLLs (because that function is long deprecated). This caused Git no longer to work on Nano Server. Instead of importing it statically, try to import it dynamically, and fall back gracefully if it cannot be loaded. This fixes #4052
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 16, 2022
The `GetNumaProcessorNode()` symbol is not defined in Nano Server's DLLs (because that function is long deprecated). This caused Git no longer to work on Nano Server. Instead of importing it statically, try to import it dynamically, and fall back gracefully if it cannot be loaded. This fixes #4052
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 17, 2022
The `GetNumaProcessorNode()` symbol is not defined in Nano Server's DLLs (because that function is long deprecated). This caused Git no longer to work on Nano Server. Instead of importing it statically, try to import it dynamically, and fall back gracefully if it cannot be loaded. This fixes #4052
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 17, 2022
The `GetNumaProcessorNode()` symbol is not defined in Nano Server's DLLs (because that function is long deprecated). This caused Git no longer to work on Nano Server. Instead of importing it statically, try to import it dynamically, and fall back gracefully if it cannot be loaded. This fixes #4052
Zeze1184
added a commit
to https-github-com-Zeze1184/git
that referenced
this pull request
Nov 22, 2022
…t-for-windows#4074)" This reverts commit 5d506d9, reversing changes made to be88dd9.
dscho
added a commit
to dscho/git-sdk-64
that referenced
this pull request
Nov 24, 2022
It was reported in git-for-windows/git#4052 that Git for Windows v2.38.0 introduced a regression where `git.exe` could no longer be run in Nano Server containers. The issue was fixed in git-for-windows/git#4074 Let's add a workflow that verifies that Git for Windows does not regress on this in the future. Signed-off-by: Johannes Schindelin <[email protected]>
dscho
added a commit
that referenced
this pull request
Jan 12, 2023
I recently [upstreamed the mimalloc fixes we developed in Git for Windows](microsoft/mimalloc#654), most notably the [fix for running in Windows Nano Server](#4074). In the meantime, that PR was accepted and a new version was created from it (that also includes a couple of other fixes). Let's integrate the latest version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
GetNumaProcessorNode()symbol is not defined in Nano Server's DLLs (because that function is long deprecated). This caused Git no longer to work on Nano Server.Instead of importing it statically, try to import it dynamically, and fall back gracefully if it cannot be loaded.
This fixes #4052