Switching out undocumented NtQueryObject for GetFileInformationByHandleEx #2377
Conversation
- Switching out undocumented (NT native) function NtQueryObject() for the documented Win32 alternative GetFileInformationByHandleEx(). - Does not fix the stalls with 'git push' for git://-protocol servers on Windows, but it's an improvement nevertheless because it avoids an undocumented function in favor for a documented one.
|
@assarbad what's your take on this PR, should it be left open, still? |
|
If you like, I can update it to match the current state of the code. I haven't looked at it in at least 2 years. Otherwise, if you don't find it desirable to use the official Win32 API, that's also fine with me and it can be closed. |
|
Wasn't the original idea to improve performance? If so, I suspect that the (undocumented) call provides better performance. |
|
@assarbad are you planning on working on this any further? |
Technically, that may even be the case. But again, it'd be the documented alternative on which you can rely going forward (and it's a fairly shallow wrapper around the native function in this case, unlike some other Win32 API functions).
@dscho Since you seem to prefer the existing use of the NT native function, I guess there's nothing left to do here. It doesn't resolve the blocking pipes issue #2376 either way 😑 |
|
Thank you for explaining your thinking, and I agree that we can leave this closed. |
NtQueryObject()forthe documented Win32 alternative
GetFileInformationByHandleEx().git pushforgit://-protocol serverson Windows, but it's an improvement nevertheless because it avoids
an undocumented function in favor for a documented one.
This is mostly meant to draw the attention to what I've tried so far ... unfortunately the underlying issue persists even with this change.
xref #2376